[GitHub] [wicket] martin-g commented on a change in pull request #475: no jira: javadoc:aggregate seems to work locally

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #475:
URL: https://github.com/apache/wicket/pull/475#discussion_r666932739



##########
File path: testing/wicket-threadtest/src/site/site.xml
##########
@@ -16,9 +16,4 @@
    limitations under the License.
 -->
 <project name="Wicket Thread Test">
-	<skin>
-		<groupId>org.apache.wicket</groupId>
-		<artifactId>wicket-site-skin</artifactId>
-		<version>1.0-SNAPSHOT</version>
-	</skin>

Review comment:
       I have no idea what that is!

##########
File path: pom.xml
##########
@@ -1020,7 +1020,6 @@
 						<failOnError>true</failOnError>
 						<doclint>none</doclint>
 						<additionalJOption>${javadoc.additionalJOption}</additionalJOption>
-						<sourcepath>${project.build.sourceDirectory}</sourcepath>

Review comment:
       I should remove this from the jpms branch too!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org