You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/31 21:51:59 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4767: Introduce a mode in the server to disable queries
Jackie-Jiang commented on a change in pull request #4767: Introduce a mode in the server to disable queries
URL: https://github.com/apache/incubator-pinot/pull/4767#discussion_r341381001
##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/HelixExternalViewBasedRouting.java
##########
@@ -222,9 +222,14 @@ private boolean isRoutingTableRebuildRequired(String tableName, ExternalView ext
previousInstanceConfig.getRecord().getSimpleField(CommonConstants.Helix.IS_SHUTDOWN_IN_PROGRESS);
String isShuttingDown =
currentInstanceConfig.getRecord().getSimpleField(CommonConstants.Helix.IS_SHUTDOWN_IN_PROGRESS);
+ String wasQueriesDisabled =
+ previousInstanceConfig.getRecord().getSimpleField(CommonConstants.Helix.QUERIES_DISABLED);
+ String isQueriesDisabled =
+ currentInstanceConfig.getRecord().getSimpleField(CommonConstants.Helix.QUERIES_DISABLED);
boolean instancesChanged =
- !EqualityUtils.isEqual(wasEnabled, isEnabled) || !EqualityUtils.isEqual(wasShuttingDown, isShuttingDown);
+ !EqualityUtils.isEqual(wasEnabled, isEnabled) || !EqualityUtils.isEqual(wasShuttingDown, isShuttingDown) ||
+ !EqualityUtils.isEqual(wasQueriesDisabled, isQueriesDisabled);
if (instancesChanged) {
LOGGER.info(
Review comment:
You should update this info log as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org