You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/03 09:33:05 UTC

[GitHub] [incubator-tvm] windclarion opened a new pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

windclarion opened a new pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990


   so the read pointer of stream can move forward, or else next read operation will read wrong data.
   
   Signed-off-by: windclarion <wi...@gmail.com>
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] zhiics merged pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

Posted by GitBox <gi...@apache.org>.
zhiics merged pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-655898541


   Thanks @windclarion @comaniac 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] windclarion commented on pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

Posted by GitBox <gi...@apache.org>.
windclarion commented on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-654535464


   The failed test is unexpected, I guess it's not caused by this modification, but I don't understand the build fail message 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] zhiics commented on pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-654353126


   Yeah, this is needed temporarily. I will change the way we initialize graph runtime so that no extra params should be fed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] windclarion edited a comment on pull request #5990: [RUNTIME] if a param not in input, we should still consume it's data

Posted by GitBox <gi...@apache.org>.
windclarion edited a comment on pull request #5990:
URL: https://github.com/apache/incubator-tvm/pull/5990#issuecomment-654535464


   The failed test is unexpected, I guess it's not caused by this modification, but I don't understand the test fail message 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org