You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/20 13:54:55 UTC
[GitHub] [apisix] jbampton opened a new pull request #3620: refactor: add the spell checker to the lint workflow
jbampton opened a new pull request #3620:
URL: https://github.com/apache/apisix/pull/3620
The spell checker only needs to run on pull request.
This also gives separate steps for each test on the pull request page instead of having `misspell` and the `merge conflict` tests as one step. Makes it easier and quicker to see which test is failing.
### What this PR does / why we need it:
Clearer to see which steps fail quicker.
### Pre-submission checklist:
* [X] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3620: refactor: add the spell checker to the lint workflow
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3620:
URL: https://github.com/apache/apisix/pull/3620#discussion_r579900257
##########
File path: .github/workflows/lint.yml
##########
@@ -36,6 +36,18 @@ jobs:
node-version: '12.x'
- run: npm install -g markdownlint-cli@0.25.0
- run: markdownlint '**/*.md'
+ spelling:
Review comment:
We already put the `spelling` in a separate file. There is no need to put it into lint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #3620: refactor: add the spell checker to the lint workflow
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #3620:
URL: https://github.com/apache/apisix/pull/3620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3620: refactor: add the spell checker to the lint workflow
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #3620:
URL: https://github.com/apache/apisix/pull/3620#discussion_r579887162
##########
File path: .github/workflows/lint.yml
##########
@@ -36,6 +36,18 @@ jobs:
node-version: '12.x'
- run: npm install -g markdownlint-cli@0.25.0
- run: markdownlint '**/*.md'
+ spelling:
Review comment:
This file is more like a linter collection, we may have a `checker` file as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org