[GitHub] sunithabeeram commented on issue #3900: Refactor in preparation for the ORCRecordReader

[GitBox <gi...@apache.org>]

sunithabeeram commented on issue #3900: Refactor in preparation for the ORCRecordReader
URL: https://github.com/apache/incubator-pinot/pull/3900#issuecomment-468814166
 
 
   Couple of suggestions:
   - We can have init() present at all times - I don't see an issue with an empty implementation for most and overridable by the readers that need it.
   - We can make the reflection based support to be more general: If the users specify a record-reader class in the segment generation config, you can instantiate it and return. If only the input format is specified, we will instantiate the default readers for specific formats. Do capture the order in which these will be handled and what happens when both are specified (we probably just need one of them to be specified to avoid confusion).
   - In the recordreader factory, allocate the record reader and before returning call init() on it; ie, move the return to the end of the getReader method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org