[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1328: Max background jobs

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1328:
URL: https://github.com/apache/incubator-kvrocks/pull/1328#discussion_r1140933407


##########
kvrocks.conf:
##########
@@ -575,15 +575,8 @@ rocksdb.target_file_size_base 128
 # allowed.
 rocksdb.max_write_buffer_number 4
 
-# Maximum number of concurrent background compaction jobs, submitted to
-# the default LOW priority thread pool.
-rocksdb.max_background_compactions 4
-
-# Maximum number of concurrent background memtable flush jobs, submitted by
-# default to the HIGH priority thread pool. If the HIGH priority thread pool
-# is configured to have zero threads, flush jobs will share the LOW priority
-# thread pool with compaction jobs.
-rocksdb.max_background_flushes 4

Review Comment:
   AFAIK it is a BREAKING CHANGE, you remove some configuration options in kvrocks.conf. You may need to explain more about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org