[jira] [Commented] (OAK-7671) [oak-run] Deprecate the datastorecheck command in favor of datastore

["Nitin Gupta (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049446#comment-17049446 ] 

Nitin Gupta commented on OAK-7671:
----------------------------------

[~thomasm] - updated the PR with the comments on the method. 

 

Also, added another option  --verbosePathInclusionRegex to provide a regex such as /*/:data to only traverse nodes that match this regex under the rootPath provided. This should help speed up the listing of lucene blobs in case of mongo mk

 

Something like --verboseRootPath /oak:index --verbosePathInclusionRegex  /*/:data,/*/:suggest-data would only scan the nodes that are necessary.

 

This would also be helpful in general as well.

 

I am still testing the changes in the PR (I did a basic round of testing on segment mk to see if everything works fine) - need to add functional tests and also do a level of performance test on mongo mk .

> [oak-run] Deprecate the datastorecheck command in favor of datastore
> --------------------------------------------------------------------
>
>                 Key: OAK-7671
>                 URL: https://issues.apache.org/jira/browse/OAK-7671
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: run
>            Reporter: Amit Jain
>            Assignee: Nitin Gupta
>            Priority: Major
>             Fix For: 1.26.0
>
>
> With the introduction of \{{datastore}} command which supports both garbage collection as well as consistency check the \{{datastorecheck}} command should be deprecated and delegated internally to use that implementation. 
> Besides some options which are currently not supported by the new command should also be implemented e.g. --ids, --refs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)