You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by David Graham <dg...@hotmail.com> on 2003/02/03 21:50:38 UTC
Re: [PATCH] for 13279
Please post this to the bugzilla ticket. We don't accept patches through
the mailing list because they tend to get lost.
David
>From: Jay <je...@vmguys.com>
>Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
>To: Struts Development <st...@jakarta.apache.org>
>Subject: [PATCH] for 13279
>Date: 03 Feb 2003 15:49:10 -0500
>
>Cedric et.al;
>
>Enclosed are two proposed patches for the "swallowing exception"
>behavior of taglib/tiles/InsertTag.java (Bugzilla #13279). The first,
>"InsertTagNoFuncChange.txt", does what I originally suggested: merely
>move the real handling of processException to a method outside of the
>inner class to a protected method in InsertTag where sub-classing and
>overriding the default behavior can easily be done.
>
>The second patch ("InsertTagFuncChange.txt") does change the behavior by
>only "swallowing" the exception when the log4j debug level is enabled
>for the class. If debug is not enabled, the exception will be wrapped
>and "re-thrown" as the root cause of a JspException.
>
>I think the second alternative is the better one because a default
>behavior of broadcasting exceptions on the web page is not particularly
>desirable. However, I will be happy if either alternative is applied
>
>I have provided complete javadoc comments for both alternatives that you
>may change as required.
>
>Thank you,
>Jay
>
>
><< InsertTagNoFuncChange.txt >>
><< InsertTagFuncChange.txt >>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
_________________________________________________________________
The new MSN 8: advanced junk mail protection and 2 months FREE*
http://join.msn.com/?page=features/junkmail
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: [PATCH] for 13279
Posted by Jay <je...@vmguys.com>.
David:
Thanks, I will do so. But you should know that I simply followed the
instructions posted on the bug database home page
(http://jakarta.apache.org/site/bugs.html):
"If you have a patch to submit, please mail it to the appropriate
developer mailing list. Use the prefix "[PATCH]" on your message
subject. Please include any relevant bug numbers . ."
Does this page need updating given your practice and perhaps the
practice of other Apache projects?
Jay
On Mon, 2003-02-03 at 15:50, David Graham wrote:
> Please post this to the bugzilla ticket. We don't accept patches through
> the mailing list because they tend to get lost.
>
> David
>
>
>
> >From: Jay <je...@vmguys.com>
> >Reply-To: "Struts Developers List" <st...@jakarta.apache.org>
> >To: Struts Development <st...@jakarta.apache.org>
> >Subject: [PATCH] for 13279
> >Date: 03 Feb 2003 15:49:10 -0500
> >
> >Cedric et.al;
> >
> >Enclosed are two proposed patches for the "swallowing exception"
> >behavior of taglib/tiles/InsertTag.java (Bugzilla #13279). The first,
> >"InsertTagNoFuncChange.txt", does what I originally suggested: merely
> >move the real handling of processException to a method outside of the
> >inner class to a protected method in InsertTag where sub-classing and
> >overriding the default behavior can easily be done.
> >
> >The second patch ("InsertTagFuncChange.txt") does change the behavior by
> >only "swallowing" the exception when the log4j debug level is enabled
> >for the class. If debug is not enabled, the exception will be wrapped
> >and "re-thrown" as the root cause of a JspException.
> >
> >I think the second alternative is the better one because a default
> >behavior of broadcasting exceptions on the web page is not particularly
> >desirable. However, I will be happy if either alternative is applied
> >
> >I have provided complete javadoc comments for both alternatives that you
> >may change as required.
> >
> >Thank you,
> >Jay
> >
> >
> ><< InsertTagNoFuncChange.txt >>
> ><< InsertTagFuncChange.txt >>
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> _________________________________________________________________
> The new MSN 8: advanced junk mail protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org