[GitHub] [beam] tvalentyn commented on a diff in pull request #25798: Add support for common collections.abc types

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #25798:
URL: https://github.com/apache/beam/pull/25798#discussion_r1134666381


##########
sdks/python/apache_beam/typehints/native_type_compatibility.py:
##########
@@ -187,6 +187,26 @@ def convert_builtin_to_typing(typ):
   return typ
 
 
+def convert_collections_to_typing(typ):
+  """Converts a given collections.abc type to a typing object.
+
+  Args:
+    typ: an object inheriting from a collections.abc object
+
+  Returns:
+    type: The corresponding typing object.
+  """
+  if hasattr(typ, '__iter__'):
+    print("here")

Review Comment:
   leftover



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org