You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@liminal.apache.org by GitBox <gi...@apache.org> on 2021/05/18 21:36:51 UTC

[GitHub] [incubator-liminal] naturalett opened a new pull request #40: [LIMINAL-64] support multiple liminal yaml files

naturalett opened a new pull request #40:
URL: https://github.com/apache/incubator-liminal/pull/40


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-liminal] aviemzur merged pull request #40: [LIMINAL-64] support multiple liminal yaml files

Posted by GitBox <gi...@apache.org>.
aviemzur merged pull request #40:
URL: https://github.com/apache/incubator-liminal/pull/40


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-liminal] aviemzur commented on a change in pull request #40: [LIMINAL-64] support multiple liminal yaml files

Posted by GitBox <gi...@apache.org>.
aviemzur commented on a change in pull request #40:
URL: https://github.com/apache/incubator-liminal/pull/40#discussion_r640492683



##########
File path: scripts/liminal
##########
@@ -129,7 +129,9 @@ def deploy_liminal_apps(path, clean):
     for config_file in config_files:
         click.echo(f"deploying liminal file: {config_file}")
         yml_name = os.path.basename(config_file)

Review comment:
       `yml_name` is no longer used, this line can be removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-liminal] aviemzur commented on a change in pull request #40: [LIMINAL-64] support multiple liminal yaml files

Posted by GitBox <gi...@apache.org>.
aviemzur commented on a change in pull request #40:
URL: https://github.com/apache/incubator-liminal/pull/40#discussion_r643736233



##########
File path: scripts/liminal
##########
@@ -129,7 +129,9 @@ def deploy_liminal_apps(path, clean):
     for config_file in config_files:
         click.echo(f"deploying liminal file: {config_file}")
         yml_name = os.path.basename(config_file)

Review comment:
       @naturalett 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org