You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 00:38:36 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #2945: Remove Unused NativeDecimalType

tustvold opened a new pull request, #2945:
URL: https://github.com/apache/arrow-rs/pull/2945

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2637 
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   Follow on to #2865 which removed the only uses of this trait
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   Technically yes, but the only users of this were removed in #2865
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ursabot commented on pull request #2945: Remove Unused NativeDecimalType

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2945:
URL: https://github.com/apache/arrow-rs/pull/2945#issuecomment-1292855850

   Benchmark runs are scheduled for baseline = 994be0589c88fa5137e8db7302e51f9b5a1bc2c2 and contender = afa8e27ce3aac2720a7684522d84b30811e61c4c. afa8e27ce3aac2720a7684522d84b30811e61c4c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5efbcb7c84bc4e8ebdac5cdbfbc83e3a...613408691c9c449a8ed8a8147a6f81d4/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b45b3c00fc9042dfa6736a1a63c6a56e...c234641924ad425c87fe1f8e5e9a40d0/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/125a9fe6fe7c4ea5887cfe154e0e65df...abb6f17092b845eb9ac08a346620bfef/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27ba4cc363f44b2b8048dbdb438dfc9f...89f877b527d043c1bc62e02c2796cc84/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #2945: Remove Unused NativeDecimalType

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2945:
URL: https://github.com/apache/arrow-rs/pull/2945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #2945: Remove Unused NativeDecimalType

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2945:
URL: https://github.com/apache/arrow-rs/pull/2945#issuecomment-1294969701

   I am pretty sure this is a api change in the semver compatible sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org