You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by ma...@apache.org on 2015/01/09 02:04:42 UTC

incubator-aurora git commit: Fix reviewbot to skip reviews that have no diffs.

Repository: incubator-aurora
Updated Branches:
  refs/heads/master 44312974f -> 47e6e68de


Fix reviewbot to skip reviews that have no diffs.

Reviewed at https://reviews.apache.org/r/29734/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/47e6e68d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/47e6e68d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/47e6e68d

Branch: refs/heads/master
Commit: 47e6e68ded428321ed7ec6ac8fffeb5d6ca97d59
Parents: 4431297
Author: Joshua Cohen <jc...@twopensource.com>
Authored: Thu Jan 8 17:04:28 2015 -0800
Committer: -l <ma...@apache.org>
Committed: Thu Jan 8 17:04:28 2015 -0800

----------------------------------------------------------------------
 build-support/jenkins/review_feedback.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/47e6e68d/build-support/jenkins/review_feedback.py
----------------------------------------------------------------------
diff --git a/build-support/jenkins/review_feedback.py b/build-support/jenkins/review_feedback.py
index bd2c994..e24f443 100755
--- a/build-support/jenkins/review_feedback.py
+++ b/build-support/jenkins/review_feedback.py
@@ -158,7 +158,11 @@ def main():
     if not _needs_reply(server, request):
       continue
 
-    latest_diff = server.get_resource(request['links']['diffs']['href'])['diffs'][-1]
+    diffs = server.get_resource(request['links']['diffs']['href'])['diffs']
+    if not diffs:
+      continue
+
+    latest_diff = diffs[-1]
     print('Applying diff %d' % latest_diff['id'])
     patch_data = server.get_resource_data(
         latest_diff['links']['self']['href'],