You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/29 17:57:51 UTC
[GitHub] [arrow-datafusion] hntd187 opened a new issue #1505: Renaming Tests Discussion
hntd187 opened a new issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
I am starting the discussion on how we want to rename some of the tests post the refactoring of the tests in #1491
**Describe the solution you'd like**
Some of the tests have names that don't necessarily have anything to do with what they are testing. Most universally the tests that begin with `csv_*` come to mind. Does that prefix have any value? I think we should just universally remove them. Maybe another suggestion maybe to instead prefix tests with what functionality they are meant to actually test?
**Describe alternatives you've considered**
Not renaming them?
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1021642464
I think this is completed in https://github.com/apache/arrow-datafusion/pull/1491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hntd187 commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
hntd187 commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1005116269
@alamb @xudong963 @liukun4515 Any opinion on this or would you prefer I just run with a PR on my own ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hntd187 commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
hntd187 commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1021824887
No @alamb this is renaming which we didn’t do in #1491 we agreed I’d do it after some discussion in this issue. I planned to get to this this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1009490957
@hntd187
any update for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
xudong963 commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1005342600
Make sense to me, looking forward to your ticket! I can help review it. @hntd187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1005196641
> Some of the tests have names that don't necessarily have anything to do with what they are testing. Most universally the tests that begin with csv_* come to mind. Does that prefix have any value? I think we should just universally remove them.
Makes sense to me
> Maybe another suggestion maybe to instead prefix tests with what functionality they are meant to actually test?
That would also be a great idea
Sorry for the lack of feedback earlier - I can't keep up with all the tickets 🤯 somedays :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1005330002
> @alamb @xudong963 @liukun4515 Any opinion on this or would you prefer I just run with a PR on my own ideas?
@hntd187 agree with you.
Some tests have the meaningless prefix, and it is not necessary.
My suggestion is that the prefix should be aligned with intend of the test.
I can start this task. If you finish it, I would like to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #1505: Renaming Tests Discussion
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1505:
URL: https://github.com/apache/arrow-datafusion/issues/1505#issuecomment-1022107436
FYI I plan to move some tests out of context.rs into the sql_integration test -- I'll try and get that done prior to the big rename 🏃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org