[GitHub] [superset] lyndsiWilliams commented on a change in pull request #15179: chore: Add tooltips and button to Connect Postgresql DB Modal Form

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on a change in pull request #15179:
URL: https://github.com/apache/superset/pull/15179#discussion_r654147707



##########
File path: superset-frontend/src/components/Form/LabeledErrorBoundInput.stories.tsx
##########
@@ -20,29 +20,26 @@ import React, { useState } from 'react';
 import LabeledErrorBoundInput, {
   LabeledErrorBoundInputProps,
 } from './LabeledErrorBoundInput';
-

Review comment:
       It looks like some spacing got removed here on line 23 and also on lines 28, 37, 45, 64, and 70, can you put them back for readability?

##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -106,8 +108,23 @@ const CredentialsInfo = ({ changeMethods, isEditMode, db }: FieldPropTypes) => {
           </span>
         </div>
       ) : (
-        <div className="input-container">
-          <span className="label-select">Upload Credentials</span>
+        <div
+          className="input-container"
+          css={(theme: SupersetTheme) => infoTooltip(theme)}
+        >
+          {/*This is missing a reqired marker. Need clarification what element to add reqired to.*/}

Review comment:
       No worries here, I can fix it on my UI polish. Go ahead and remove this comment and I'll take care of the required bit 😁 

##########
File path: superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx
##########
@@ -19,9 +19,9 @@
 import React from 'react';
 import { Input } from 'antd';
 import { styled, css, SupersetTheme } from '@superset-ui/core';
+import InfoTooltip from 'src/components/InfoTooltip';
 import FormItem from './FormItem';
 import FormLabel from './FormLabel';
-

Review comment:
       It looks like some spacing got removed here on line 24 and also on lines 37, 41, 49, 75 and 101, can you put them back for readability?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org