You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Pearl1594 (via GitHub)" <gi...@apache.org> on 2025/08/08 11:28:20 UTC
[PR] Add support for CSI driver in CKS [cloudstack]
Pearl1594 opened a new pull request, #11419:
URL: https://github.com/apache/cloudstack/pull/11419
### Description
This PR adds support to deploy the CSI driver when deploying CKS clusters. It isn't setup by default, only done when the enablecsi parameter is passed. Also added support for snapshot related APIs for the project level user to allow snapshots of persistent volumes at project level
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3222629199
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3389096424
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3385405581
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#discussion_r2416627974
##########
plugins/integrations/kubernetes-service/src/main/resources/script/deploy-csi-driver:
##########
@@ -0,0 +1,46 @@
+#!/bin/bash -e
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+(/opt/bin/kubectl get pods -A | grep cloudstack-csi-controller) && exit 0
+
+if [ -e /opt/csi/snapshot-crds.yaml ]; then
+ /opt/bin/kubectl apply -f /opt/csi/snapshot-crds.yaml
+ sleep 5
+ /opt/bin/kubectl apply -f /opt/csi/manifest.yaml
+ exit 0
+else
+ TARGET_DIR="/opt/csi"
+ mkdir -p "$TARGET_DIR"
+ CSI_URLS=(
+ "https://github.com/cloudstack/cloudstack-csi-driver/releases/download/v3.0.0/snapshot-crds.yaml"
+ "https://github.com/cloudstack/cloudstack-csi-driver/releases/download/v3.0.0/manifest.yaml"
+ )
+ for url in "${URLS[@]}"; do
Review Comment:
Variable name mismatch: the loop uses `URLS[@]` but the array is defined as `CSI_URLS` on line 29. This will cause the loop to fail.
```suggestion
for url in "${CSI_URLS[@]}"; do
```
##########
plugins/integrations/kubernetes-service/src/main/resources/script/deploy-csi-driver:
##########
@@ -0,0 +1,46 @@
+#!/bin/bash -e
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+(/opt/bin/kubectl get pods -A | grep cloudstack-csi-controller) && exit 0
+
+if [ -e /opt/csi/snapshot-crds.yaml ]; then
+ /opt/bin/kubectl apply -f /opt/csi/snapshot-crds.yaml
+ sleep 5
+ /opt/bin/kubectl apply -f /opt/csi/manifest.yaml
+ exit 0
+else
+ TARGET_DIR="/opt/csi"
+ mkdir -p "$TARGET_DIR"
+ CSI_URLS=(
+ "https://github.com/cloudstack/cloudstack-csi-driver/releases/download/v3.0.0/snapshot-crds.yaml"
+ "https://github.com/cloudstack/cloudstack-csi-driver/releases/download/v3.0.0/manifest.yaml"
+ )
+ for url in "${URLS[@]}"; do
+ filename=$(basename "$url")
+
+ curl -sSL ${url} -o ${working_dir}/${filename}
Review Comment:
Variable `working_dir` is not defined in this script. This should likely be `$TARGET_DIR` which is defined on line 27.
```suggestion
curl -sSL ${url} -o ${TARGET_DIR}/${filename}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3385649021
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3387478268
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3392495974
<b>[SF] Trillian test result (tid-14606)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59961 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11419-t14606-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3201589838
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3168873732
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3210699008
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [26.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3222887996
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3390098509
@kiranchavala I observed this failure even without the csi changes, Im investigating. Thanks for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3387278942
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3201505298
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11419?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.63%. Comparing base ([`f2d6356`](https://app.codecov.io/gh/apache/cloudstack/commit/f2d635683bf75baf1251c4326a8947572df13ba6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`19297e0`](https://app.codecov.io/gh/apache/cloudstack/commit/19297e05f4a2644f353af311db4a94a82709b76c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (f2d6356) and HEAD (19297e0). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (f2d6356) | HEAD (19297e0) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11419 +/- ##
=============================================
- Coverage 17.35% 3.63% -13.73%
=============================================
Files 5886 441 -5445
Lines 525685 37025 -488660
Branches 64159 6786 -57373
=============================================
- Hits 91247 1345 -89902
+ Misses 424138 35519 -388619
+ Partials 10300 161 -10139
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11419/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.63% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11419?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3385962910
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [17.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3386001104
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3385834479
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3222632794
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3378057649
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [17.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#discussion_r2416482413
##########
engine/schema/src/main/resources/META-INF/db/schema-42010to42100.sql:
##########
@@ -757,3 +757,6 @@ SET `cs`.`domain_id` = (
-- Re-apply VPC: update default network offering for vpc tier to conserve_mode=1 (#8309)
UPDATE `cloud`.`network_offerings` SET conserve_mode = 1 WHERE name = 'DefaultIsolatedNetworkOfferingForVpcNetworks';
+
+-- Add csi_enabled column to kubernetes_cluster table - Move to 4.22
Review Comment:
Please move this to 4.22 sql file.
##########
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java:
##########
@@ -207,6 +207,9 @@ public class CreateKubernetesClusterCmd extends BaseAsyncCreateCmd {
since = "4.21.0")
private Map cniConfigDetails;
+ @Parameter(name = ApiConstants.ENABLE_CSI, type = CommandType.BOOLEAN, description = "if true, setups up CloudStack CSI driver", since = "4.21.0")
Review Comment:
pls change to 4.22.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 closed pull request #11419: Add support for CSI driver in CKS
URL: https://github.com/apache/cloudstack/pull/11419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3387276567
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3385408358
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3272649544
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [17.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3201731967
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [26.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3401484689
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [17.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3234586232
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [26.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3386209710
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419) **Quality Gate failed**
Failed conditions
 [1.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_coverage&view=list) (required ≥ 40%)
 [17.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11419&metric=new_duplicated_lines_density&view=list) (required ≤ 10%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3388283116
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for CSI driver in CKS [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11419:
URL: https://github.com/apache/cloudstack/pull/11419#issuecomment-3388285996
@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org