You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/03/31 01:29:40 UTC

[GitHub] [spark] cloud-fan commented on pull request #40601: [SPARK-42975][SQL] Cast result type to timestamp type for string +/- interval

cloud-fan commented on PR #40601:
URL: https://github.com/apache/spark/pull/40601#issuecomment-1491166217

   The change makes sense, but I'd say this is a legacy feature and the existing behavior doesn't make sense at all. For string +/- internal, the string can be timestamp, timestamp_ntz and interval, there is no correct behavior here.
   
   My suggestion is don't touch it to keep legacy workloads running. We should update the SQL queries to not use String so extensively.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org