[GitHub] [incubator-weex] weex-bot commented on issue #2829: Revert "[Android] Android] restart weexCoreThread when reload JSEngin…

[GitBox <gi...@apache.org>]

weex-bot commented on issue #2829: Revert "[Android] Android] restart weexCoreThread when reload JSEngin…
URL: https://github.com/apache/incubator-weex/pull/2829#issuecomment-521501778
 
 
   
   <!--
     0 failure: 
     4 warning:  Potential BREAK C..., No Changelog chan..., Current pr not bi..., If your PR is abo...
     1 messages
     
     DangerID: danger-id-danger;
   -->
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Messages</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:book:</td>
         <td>danger test finished.</td>
       </tr>
     </tbody>
   </table>
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 96f05bd6a64c3473960e456b1647ab3c700c24c2
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services