You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/09 14:10:13 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm

wu-sheng commented on pull request #5274:
URL: https://github.com/apache/skywalking/pull/5274#issuecomment-671056513


   > With reflection we support oracle/sun and ibm jvm and maybe other jvm
   
   This is the thing which should be enhanced. You never need a config to activate this accessor. You could use the reflection too. If the target class(es)/method(s) found, then this could be activated. 
   The current accessor should be the default. 
   
   You should not use SPI(this word), there is no SPI. SPI is the JVM level mechanism.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org