[GitHub] [spark] cloud-fan commented on a diff in pull request #37453: [SPARK-40019][SQL] Refactor comment and logic of ArrayType's containsNull

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37453:
URL: https://github.com/apache/spark/pull/37453#discussion_r943053914


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -1079,6 +1084,9 @@ case class Shuffle(child: Expression, randomSeed: Option[Long] = None)
 
   override def dataType: DataType = child.dataType
 
+  @transient private lazy val resultArrayElementNullable =

Review Comment:
   ```suggestion
     private def resultArrayElementNullable =
   ```



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -1162,6 +1170,9 @@ case class Reverse(child: Expression)
 
   override def dataType: DataType = child.dataType
 
+  @transient private lazy val resultArrayElementNullable =

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org