You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/06 18:44:40 UTC
Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for I/O
switchboard.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54434/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Kevin Klues.
Repository: mesos
Description
-------
Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
Diff: https://reviews.apache.org/r/54434/diff/
Testing
-------
make check on both osx and linux
Thanks,
Jie Yu
Re: Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for
I/O switchboard.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54434/#review158277
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Dec. 6, 2016, 6:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54434/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
> src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
>
> Diff: https://reviews.apache.org/r/54434/diff/
>
>
> Testing
> -------
>
> make check on both osx and linux
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for
I/O switchboard.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54434/#review158439
-----------------------------------------------------------
Ship it!
This looks great Jie!
- Benjamin Hindman
On Dec. 6, 2016, 6:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54434/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
> src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
>
> Diff: https://reviews.apache.org/r/54434/diff/
>
>
> Testing
> -------
>
> make check on both osx and linux
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54434: Used UNSET_CLOEXEC instead of DUP2 hook for
I/O switchboard.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54434/#review158281
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54432, 54433, 54434]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 6, 2016, 6:44 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54434/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 6:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used UNSET_CLOEXEC instead of DUP2 hook for I/O switchboard.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065
> src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
>
> Diff: https://reviews.apache.org/r/54434/diff/
>
>
> Testing
> -------
>
> make check on both osx and linux
>
>
> Thanks,
>
> Jie Yu
>
>