You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2014/04/21 18:57:43 UTC
svn commit: r1588927 -
/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java
Author: schor
Date: Mon Apr 21 16:57:43 2014
New Revision: 1588927
URL: http://svn.apache.org/r1588927
Log:
no Jira - make one more private ref "final"
Modified:
uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java
Modified: uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java?rev=1588927&r1=1588926&r2=1588927&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/impl/CasManager_impl.java Mon Apr 21 16:57:43 2014
@@ -57,7 +57,7 @@ import org.apache.uima.util.impl.CasPool
* An instance of this class might be accessed in parallel on different threads.
*/
public class CasManager_impl implements CasManager {
- private ResourceManager mResourceManager;
+ private final ResourceManager mResourceManager;
/**
* accumulates the metadata needed for shared CASes for this resource manager
@@ -102,7 +102,7 @@ public class CasManager_impl implements
throw new UIMARuntimeException(UIMARuntimeException.ILLEGAL_ADDING_OF_NEW_META_INFO_AFTER_CAS_DEFINED, new Object[] {}); // internal error UIMA-1249
}
mMetaDataList.add(aMetaData);
-// mCasDefinition = null; // mark this stale
+// mCasDefinition = null; // marka this stale
// mCurrentTypeSystem = null; //this too
}
@@ -227,6 +227,7 @@ public class CasManager_impl implements
* Defines a CAS pool using either a UimaContext or the name of a UimaContext.
* synchronized because it tests, then sets "pool"
*/
+ // this sync seems involved
private synchronized void defineCasPool(UimaContext aRequestorContext, String aRequestorContextName, int aMinimumSize,
Properties aPerformanceTuningSettings) throws ResourceInitializationException {
int poolSize = getCasPoolSize(aRequestorContextName, aMinimumSize);