You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/06 18:26:51 UTC

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #313: Bootintobios

shwstppr commented on a change in pull request #313:
URL: https://github.com/apache/cloudstack-primate/pull/313#discussion_r421001878



##########
File path: src/config/section/compute.js
##########
@@ -104,7 +104,8 @@ export default {
           icon: 'reload',
           label: 'label.action.reboot.instance',
           dataView: true,
-          show: (record) => { return ['Running'].includes(record.state) }
+          show: (record) => { return ['Running'].includes(record.state) },
+          args: ['bootintosetup']

Review comment:
       ```suggestion
             args: (record) => { return record.hypervisor === 'VMware' ? ['bootintosetup'] : [] }
   ```
   @DaanHoogland 
   This should work but currently it seems record is coming undefined from AutogenView. I've created PR #327 to fix that.
   `record` here will be the response for `listvirtualmachinesmetrics` response item




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org