[jira] Commented: (DIRLDAP-43) Refactor Attributes implementations

["Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>]

    [ http://issues.apache.org/jira/browse/DIRLDAP-43?page=comments#action_12356012 ] 

Emmanuel Lecharny commented on DIRLDAP-43:
------------------------------------------

The specific LockableAttributeImpl class muts be refactored in two directions :
- as Alex said, 'Lockability' is useless. 
- much more important, the class *must* be aware of it's attribute type. A user could perfectly store a String or a byte array in an attribute, depending on the attribute type being binary or not. Actually, it is supposed to be a String, and this is not the best option. We should accept byte[].

The following transformation table should be applied :

    Attribute's type  client type server type
       String                   String        String
       String                   byte[]         String
       OctetString          String         byte[]
       OctetString          byte[]         byte[]
       whatever             XXX           error    where XXX is not String or Byte

    

> Refactor Attributes implementations
> -----------------------------------
>
>          Key: DIRLDAP-43
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-43
>      Project: Directory LDAP
>         Type: Improvement
>     Versions: 0.9.0
>     Reporter: Trustin Lee
>     Assignee: Alex Karasulu
>      Fix For: 0.9.3

>
> There are a few implementations of JNDI Attributes type, but some of they seem to exist due to historical reason.  Let's review and replace them with BasicAttributes if necessary.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira