You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/12/03 10:19:10 UTC
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/511
Cron UI fix and css cleanup
- add spacing between links in presets
- remove inline css and fix alignment
Before
<img width="324" alt="screen shot 2015-12-03 at 2 02 13 pm" src="https://cloud.githubusercontent.com/assets/2031306/11556393/4cdbe888-99cc-11e5-8efc-2384dd884a98.png">
<img width="322" alt="screen shot 2015-12-03 at 2 46 27 pm" src="https://cloud.githubusercontent.com/assets/2031306/11556450/acb90826-99cc-11e5-921b-4125fc0deb05.png">
<hr />
After
<img width="331" alt="screen shot 2015-12-03 at 2 01 30 pm" src="https://cloud.githubusercontent.com/assets/2031306/11556394/4ce3a852-99cc-11e5-9ec1-86d54163a727.png">
<img width="313" alt="screen shot 2015-12-03 at 2 48 17 pm" src="https://cloud.githubusercontent.com/assets/2031306/11556475/edd94686-99cc-11e5-96ed-18c804b114fa.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin cronUIFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #511
----
commit 7aa6f5c3ab441918890a9ca458668d74c550c212
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-12-03T09:10:53Z
Cron UI fix and css cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161568060
@corneadoug currently it is 2px. will update to 5px
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161844842
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161568503
@corneadoug 87c21cd
<img width="320" alt="screen shot 2015-12-03 at 3 08 57 pm" src="https://cloud.githubusercontent.com/assets/2031306/11556938/ce510db4-99cf-11e5-8f55-e15704f9e4cb.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161568654
:+1: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by swkimme <gi...@git.apache.org>.
Github user swkimme commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161562192
LGTM!
2015년 12월 3일 (목) 오후 6:19, Renjith Kamath <no...@github.com>님이 작성:
>
> - add spacing between links in presets
> - remove inline css and fix alignment
>
> Before
> [image: screen shot 2015-12-03 at 2 02 13 pm]
> <https://cloud.githubusercontent.com/assets/2031306/11556393/4cdbe888-99cc-11e5-8efc-2384dd884a98.png>
> [image: screen shot 2015-12-03 at 2 46 27 pm]
> <https://cloud.githubusercontent.com/assets/2031306/11556450/acb90826-99cc-11e5-921b-4125fc0deb05.png>
> ------------------------------
>
> After
> [image: screen shot 2015-12-03 at 2 01 30 pm]
> <https://cloud.githubusercontent.com/assets/2031306/11556394/4ce3a852-99cc-11e5-9ec1-86d54163a727.png>
> [image: screen shot 2015-12-03 at 2 48 17 pm]
> <https://cloud.githubusercontent.com/assets/2031306/11556475/edd94686-99cc-11e5-96ed-18c804b114fa.png>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/incubator-zeppelin/pull/511
> Commit Summary
>
> - Cron UI fix and css cleanup
>
> File Changes
>
> - *M* zeppelin-web/src/app/notebook/notebook.css
> <https://github.com/apache/incubator-zeppelin/pull/511/files#diff-0>
> (26)
> - *M* zeppelin-web/src/app/notebook/notebook.html
> <https://github.com/apache/incubator-zeppelin/pull/511/files#diff-1>
> (36)
>
> Patch Links:
>
> - https://github.com/apache/incubator-zeppelin/pull/511.patch
> - https://github.com/apache/incubator-zeppelin/pull/511.diff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/511>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161564788
Could you also add a bit more spacing between the Cron expresion and its error message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Cron UI fix and css cleanup
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/511#issuecomment-161570683
Its better thanks.
Ready For Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---