[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1603: Ftr/triple reflect support

[GitBox <gi...@apache.org>]

Mulavar commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753784200



##########
File path: config/service_config.go
##########
@@ -51,7 +51,7 @@ type ServiceConfig struct {
 	id                          string
 	Filter                      string            `yaml:"filter" json:"filter,omitempty" property:"filter"`
 	ProtocolIDs                 []string          `yaml:"protocol-ids"  json:"protocol-ids,omitempty" property:"protocol-ids"` // multi protocolIDs support, split by ','
-	Interface                   string            `validate:"required"  yaml:"interface"  json:"interface,omitempty" property:"interface"`

Review comment:
       这里 validate tag 和上面的 required tag 应该是分别做两个事，上面的 required 删掉我理解，因为如果不设置值就尝试使用 pb 里的值，但这里的 validate 为啥删掉呢，pb 里读到的不需要校验嘛？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org