You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2007/01/27 00:58:49 UTC

[jira] Created: (HADOOP-943) fsck to show the filename of the corrupted file

fsck to show the filename of the corrupted file
-----------------------------------------------

                 Key: HADOOP-943
                 URL: https://issues.apache.org/jira/browse/HADOOP-943
             Project: Hadoop
          Issue Type: Improvement
            Reporter: Koji Noguchi
            Priority: Trivial


When fsck / shows some corrupted file/block information, 

*******************************
CORRUPT FILES:  1
MISSING BLOCKS: 1
MISSING SIZE:   ___ B
********************************

it doesn't show the filename.  

I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 






-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-943:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.12.0
           Status: Resolved  (was: Patch Available)

I just committed this.  Thanks, Dhruba.

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>             Fix For: 0.12.0
>
>         Attachments: fsckPrintCorrupt.patch
>
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-943:
------------------------------------

    Attachment: fsckPrintCorrupt.patch

When fsck detects under-replicated blocks or corrupted blocks, it prints out the corresponding filename. 

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>         Attachments: fsckPrintCorrupt.patch
>
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-943:
------------------------------------

    Status: Patch Available  (was: Open)

I would like to defer the requirement "make the output of fsck machine readable" to a separate JIRA issue.

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>         Attachments: fsckPrintCorrupt.patch
>
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471488 ] 

Koji Noguchi commented on HADOOP-943:
-------------------------------------

It'll be nice if this can also print ouf the info(file/block)  for under-replicated blocks.


> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>            Priority: Trivial
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Noguchi updated HADOOP-943:
--------------------------------

    Component/s: dfs

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>            Priority: Trivial
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473264 ] 

Milind Bhandarkar commented on HADOOP-943:
------------------------------------------

+1 patch reviewed.

Dhruba,

Can we eliminate the printing of '.' in fsck ? That would simplify processing the report mechanically. It is tricky though, because the http client may timeout on a large fsck printing all its output at the end.

For -files, -blocks, -locations, can we make the fsck output more machine-processable (say limiting info about each file to a single line?)

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>         Attachments: fsckPrintCorrupt.patch
>
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473286 ] 

Hadoop QA commented on HADOOP-943:
----------------------------------

+1, because http://issues.apache.org/jira/secure/attachment/12351197/fsckPrintCorrupt.patch applied and successfully tested against trunk revision r507276.

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>         Attachments: fsckPrintCorrupt.patch
>
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur reassigned HADOOP-943:
---------------------------------------

    Assignee: dhruba borthakur

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>         Assigned To: dhruba borthakur
>            Priority: Trivial
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-943) fsck to show the filename of the corrupted file

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473164 ] 

dhruba borthakur commented on HADOOP-943:
-----------------------------------------

In the current implementation, underReplicatedBlocks is actually the distance of all blocks from their target replication factor. For example, if there were two blocks whose target replication factor was 3 and each of those blocks had one replica, then fsck will display underReplicatedBlocks as 4.

My change will display underReplicatedBlocks as 2 in the above case.

> fsck to show the filename of the corrupted file
> -----------------------------------------------
>
>                 Key: HADOOP-943
>                 URL: https://issues.apache.org/jira/browse/HADOOP-943
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Koji Noguchi
>            Priority: Trivial
>
> When fsck / shows some corrupted file/block information, 
> *******************************
> CORRUPT FILES:  1
> MISSING BLOCKS: 1
> MISSING SIZE:   ___ B
> ********************************
> it doesn't show the filename.  
> I can run fsck /  -files  again, but this would take a lot longer than the plain fsck. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.