You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:25:10 UTC

[GitHub] [druid] jihoonson commented on a change in pull request #9994: remove incorrect and unnecessary overrides from BooleanVectorValueMatcher

jihoonson commented on a change in pull request #9994:
URL: https://github.com/apache/druid/pull/9994#discussion_r436853237



##########
File path: processing/src/main/java/org/apache/druid/query/filter/vector/BooleanVectorValueMatcher.java
##########
@@ -38,18 +36,6 @@ public static BooleanVectorValueMatcher of(final VectorSizeInspector selector, f
     return new BooleanVectorValueMatcher(selector, matches);
   }
 
-  @Override
-  public int getCurrentVectorSize()
-  {
-    return selector.getCurrentVectorSize();

Review comment:
       nit: maybe good to have unit tests for future proof.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org