[jira] [Commented] (SOLR-5648) SolrCore#getStatistics() should nest open searchers' stats

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907825#comment-13907825 ] 

Hoss Man commented on SOLR-5648:
--------------------------------

1) I'm not sure i really understand what this adds -- isn't every registered searcher (which should include every open searcher if there are more then one) already listed in the infoRegistry (so it's stats are surfaced in /admin/mbeans and via JMX) ?

2) having a searchLock in getStatistics scares me ... seems like a recipe for all sorts of inexplicable performance oddities on opening new searchers just because a monitoring agent (or 10) polls all stats every second.

> SolrCore#getStatistics() should nest open searchers' stats
> ----------------------------------------------------------
>
>                 Key: SOLR-5648
>                 URL: https://issues.apache.org/jira/browse/SOLR-5648
>             Project: Solr
>          Issue Type: Task
>            Reporter: Shikhar Bhushan
>            Priority: Minor
>             Fix For: 4.7
>
>         Attachments: SOLR-5648.patch, oldestSearcherStaleness.gif, openSearchers.gif
>
>
> {{SolrIndexSearcher}} leaks are a notable cause of garbage collection issues in codebases with custom components.
> So it is useful to be able to access monitoring information about what searchers are currently open, and in turn access their stats e.g. {{openedAt}}.
> This can be nested via {{SolrCore#getStatistics()}} which has a {{_searchers}} collection of all open searchers.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org