You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/09/12 14:36:33 UTC
[jira] [Commented] (ISIS-879) ObjectMemberAbstract#isAlwaysHidden()
does not honour where=Where.EVERYWHERE.
[ https://issues.apache.org/jira/browse/ISIS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131483#comment-14131483 ]
ASF subversion and git services commented on ISIS-879:
------------------------------------------------------
Commit ad8f8a82c93fe877d55555b01aedd27d3ce42bd0 in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ad8f8a8 ]
ISIS-879: fix for ObjectMemberAbstract#isAlwaysHidden
... wasn't handling no-op facets nor dealing with fact that Where.ANYWHERE and Where.EVERYWHERE are meant to be synonyms.
> ObjectMemberAbstract#isAlwaysHidden() does not honour where=Where.EVERYWHERE.
> -----------------------------------------------------------------------------
>
> Key: ISIS-879
> URL: https://issues.apache.org/jira/browse/ISIS-879
> Project: Isis
> Issue Type: Bug
> Components: Core
> Affects Versions: core-1.6.0
> Reporter: Dan Haywood
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: core-1.7.0
>
>
> in ApplicationFeatures
> protected boolean isHidden(ObjectSpecification spec) {
> final HiddenFacet facet = spec.getFacet(HiddenFacet.class);
> return facet != null &&
> !facet.isNoop() &&
> (facet.where() == Where.EVERYWHERE || facet.where() == Where.ANYWHERE) &&
> facet.when() == When.ALWAYS;
> }
>
> in ObjectMemberAbstract
> @Override
> public boolean isAlwaysHidden() {
> final HiddenFacet hiddenFacet = getFacet(HiddenFacet.class);
> return hiddenFacet != null && hiddenFacet.when() == When.ALWAYS && hiddenFacet.where() == Where.ANYWHERE;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)