You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/20 12:15:56 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request #5474: change logging during upgrade
DaanHoogland opened a new pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-923060288
No need to run tests on this PR, simple logging refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-923057001
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-922886592
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-923030891
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#discussion_r712164487
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
Review comment:
```suggestion
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:" + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-922930773
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#discussion_r712165941
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
}
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
} catch (SQLException e) {
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
Review comment:
```suggestion
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#discussion_r712165667
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
}
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
Review comment:
```suggestion
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-922931488
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-922888388
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#issuecomment-923029240
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5474: change logging during upgrade
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5474:
URL: https://github.com/apache/cloudstack/pull/5474#discussion_r712165210
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
+ if (s_logger.isTraceEnabled()) {
+ s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
+ }
//implies iso_id1 is not present, so do nothing.
}
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
Review comment:
```suggestion
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
```
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
##########
@@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
- s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
+ s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception:"+e.getMessage());
Review comment:
```suggestion
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org