You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/10/07 05:54:24 UTC

[GitHub] [netbeans] jGauravGupta opened a new pull request #3219: Fixes creation of a Glassfish deployment descriptor

jGauravGupta opened a new pull request #3219:
URL: https://github.com/apache/netbeans/pull/3219


   This is a bug fix PR that fixes the creation of `glassfish-web.xml` deployment descriptor.
   
   **Issue 1:**
   
   If the server is not assigned to the project then glassfish-web.xml path is also incorrect.
   
   - Server attached then descriptor path: webapp/WEB-INF/glassfish-web.xml
   - Server is not attached then the descriptor path: webapp/glassfish-web.xml
   
   Fixed by checking the relative path of standard DD `web.xml`.
   
   **Issue 2:**
   
   Old Java EE and J2EE `glassfish-web.xml` templates no more exist and check for WebApp version 4.0 not added to `getSunDDFromProjectsModuleVersion` which skips the creation of `glassfish-web.xml`.
   
   Fixed by returning the template `org-netbeans-modules-glassfish-eecommon-ddtemplates-java_ee/glassfish-web.xml`.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] jGauravGupta merged pull request #3219: Fixes creation of a Glassfish deployment descriptor

Posted by GitBox <gi...@apache.org>.
jGauravGupta merged pull request #3219:
URL: https://github.com/apache/netbeans/pull/3219


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists