You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/24 21:48:58 UTC

[GitHub] DickJC123 commented on issue #7597: fix for amalgamation build with MIN=1

DickJC123 commented on issue #7597: fix for amalgamation build with MIN=1
URL: https://github.com/apache/incubator-mxnet/pull/7597#issuecomment-324766936
 
 
   I was in the process of switching the 21 uses of dot() over to linalg_gemm when I noticed this change.  If the preferred long-term interface is linalg_gemm, why don't I just modify linalg_impl.h to check MSHADOW_USE_CBLAS and invoke dot(), rather than have this ifdef sequence repeated in many places?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services