You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/29 13:25:55 UTC

[GitHub] [kafka] mumrah commented on a diff in pull request #12455: KAFKA-14111 Fix sensitive dynamic broker configs in KRaft

mumrah commented on code in PR #12455:
URL: https://github.com/apache/kafka/pull/12455#discussion_r933262928


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -1493,6 +1493,7 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami
 
   // Cache the current config to avoid acquiring read lock to access from dynamicConfig
   @volatile private var currentConfig = this
+  val processRoles: Set[ProcessRole] = parseProcessRoles()

Review Comment:
   On the line below, we are creating the DynamicBrokerConfig which gets a partially initialized KafkaConfig. Moving `parseProcessRoles` up here was simpler than refactoring a bunch of this config code :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org