You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/18 16:06:55 UTC
[GitHub] [flink] wenlong88 opened a new pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
wenlong88 opened a new pull request #15271:
URL: https://github.com/apache/flink/pull/15271
## What is the purpose of the change
Support json ser/de for StreamExecOverAggregate
## Brief change log
Support json ser/de for StreamExecOverAggregate
## Verifying this change
This change added tests and can be verified as follows:
1. OverAggregateJsonPlanTest and OverAggregateJsonPlanITCase are added to verify the ser/de
2. RexWindowBoundSerdeTest is added to verify the ser/de of RexWindowBound
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #15271:
URL: https://github.com/apache/flink/pull/15271#discussion_r597445044
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexLiteralJsonDeserializer.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonParser;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.DeserializationContext;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+
+import org.apache.calcite.rex.RexLiteral;
+import org.apache.calcite.rex.RexNode;
+
+import java.io.IOException;
+
+/**
+ * JSON deserializer for {@link RexLiteral}. refer to {@link RexNodeJsonSerializer} for serializer.
+ */
+public class RexLiteralJsonDeserializer extends StdDeserializer<RexLiteral> {
Review comment:
I am afraid not, this class is a wrapper of RexNodeJsonDeserializer, which is used to deserialize List<RexLiteral>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9800b92650659d48d1abfe6974b4fe1b9cb5257f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986)
* bef4e943848053624fa307a294e0476ffab58652 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
}, {
"hash" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bef4e943848053624fa307a294e0476ffab58652 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006)
* 6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802053607
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9800b92650659d48d1abfe6974b4fe1b9cb5257f (Thu Mar 18 16:08:59 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9800b92650659d48d1abfe6974b4fe1b9cb5257f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986)
* bef4e943848053624fa307a294e0476ffab58652 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #15271:
URL: https://github.com/apache/flink/pull/15271#discussion_r597419527
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexLiteralJsonDeserializer.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonParser;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonProcessingException;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.DeserializationContext;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+
+import org.apache.calcite.rex.RexLiteral;
+import org.apache.calcite.rex.RexNode;
+
+import java.io.IOException;
+
+/**
+ * JSON deserializer for {@link RexLiteral}. refer to {@link RexNodeJsonSerializer} for serializer.
+ */
+public class RexLiteralJsonDeserializer extends StdDeserializer<RexLiteral> {
Review comment:
can we use RexNodeJsonDeserializer to replace this?
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexWindowBoundJsonDeserializer.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.table.api.TableException;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonParser;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.DeserializationContext;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexWindowBound;
+import org.apache.calcite.rex.RexWindowBounds;
+
+import java.io.IOException;
+
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_IS_FOLLOWING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_IS_PRECEDING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_KIND;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_OFFSET;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_BOUNDED_WINDOW;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_CURRENT_ROW;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_UNBOUNDED_FOLLOWING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_UNBOUNDED_PRECEDING;
+
+/**
+ * JSON deserializer for {@link RexWindowBound}. refer to {@link RexWindowBoundJsonSerializer} for
+ * serializer.
+ */
+public class RexWindowBoundJsonDeserializer extends StdDeserializer<RexWindowBound> {
Review comment:
nit: add serialVersionUID
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/OverSpec.java
##########
@@ -83,24 +108,40 @@ public int getOriginalInputFields() {
* <p>This class corresponds to {@link org.apache.calcite.rel.core.Window.Group}, but different
* from Group, the partition spec is defined in OverSpec.
*/
+ @JsonIgnoreProperties(ignoreUnknown = true)
public static class GroupSpec {
+ public static final String FIELD_NAME_SORT_SPEC = "sortSpec";
Review comment:
"orderBy" ?
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/OverSpec.java
##########
@@ -33,42 +43,57 @@
* <p>This class corresponds to {@link org.apache.calcite.rel.core.Window} rel node, different from
* Window rel, OverSpec requires all groups should have same partition.
*/
+@JsonIgnoreProperties(ignoreUnknown = true)
public class OverSpec {
+ public static final String FIELD_NAME_PARTITION = "partition";
+ public static final String FIELD_NAME_GROUPS = "groups";
+ public static final String FIELD_NAME_CONSTANTS = "constants";
+ public static final String FIELD_NAME_INPUT_FIELD_NUM = "inputFieldNum";
Review comment:
use `originalInputFields`? because for batch over node, the fields is the original fields of logical over node, which may be split into multiple physical over nodes
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexWindowBoundJsonSerializer.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.table.api.TableException;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.SerializerProvider;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ser.std.StdSerializer;
+
+import org.apache.calcite.rex.RexWindowBound;
+
+import java.io.IOException;
+
+/**
+ * JSON serializer for {@link RexWindowBound}. refer to {@link RexWindowBoundJsonDeserializer} for
+ * deserializer.
+ *
+ * <p>Supports serialize CURRENT_ROW, UNBOUNDED_PRECEDING, UNBOUNDED_FOLLOWING, Preceding Bounded
+ * Window and Following Bounded Window.
+ */
+public class RexWindowBoundJsonSerializer extends StdSerializer<RexWindowBound> {
Review comment:
nit: add serialVersionUID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bef4e943848053624fa307a294e0476ffab58652 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #15271:
URL: https://github.com/apache/flink/pull/15271#discussion_r597465142
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexWindowBoundJsonDeserializer.java
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.table.api.TableException;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonParser;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.DeserializationContext;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexWindowBound;
+import org.apache.calcite.rex.RexWindowBounds;
+
+import java.io.IOException;
+
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_IS_FOLLOWING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_IS_PRECEDING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_KIND;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.FIELD_NAME_OFFSET;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_BOUNDED_WINDOW;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_CURRENT_ROW;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_UNBOUNDED_FOLLOWING;
+import static org.apache.flink.table.planner.plan.nodes.exec.serde.RexWindowBoundJsonSerializer.KIND_UNBOUNDED_PRECEDING;
+
+/**
+ * JSON deserializer for {@link RexWindowBound}. refer to {@link RexWindowBoundJsonSerializer} for
+ * serializer.
+ */
+public class RexWindowBoundJsonDeserializer extends StdDeserializer<RexWindowBound> {
Review comment:
we don't need serialVersionUID here i think, because we do need to serialize the XXDeserializer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9800b92650659d48d1abfe6974b4fe1b9cb5257f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9800b92650659d48d1abfe6974b4fe1b9cb5257f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #15271:
URL: https://github.com/apache/flink/pull/15271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
}, {
"hash" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15021",
"triggerID" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bef4e943848053624fa307a294e0476ffab58652 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006)
* 6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
}, {
"hash" : "bef4e943848053624fa307a294e0476ffab58652",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15006",
"triggerID" : "bef4e943848053624fa307a294e0476ffab58652",
"triggerType" : "PUSH"
}, {
"hash" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15021",
"triggerID" : "6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f6e74dbb3b009c49c81c155e5a0cfa3f1d8a300 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15271: [FLINK-21813][table-planner-blink] Support json ser/de for StreamExecOverAggregate
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15271:
URL: https://github.com/apache/flink/pull/15271#issuecomment-802067101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986",
"triggerID" : "9800b92650659d48d1abfe6974b4fe1b9cb5257f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9800b92650659d48d1abfe6974b4fe1b9cb5257f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14986)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org