[GitHub] [ignite] sk0x50 commented on a change in pull request #7607: IGNITE-11073: Create consistent partitions copy on each cluster node

[GitBox <gi...@apache.org>]

sk0x50 commented on a change in pull request #7607:
URL: https://github.com/apache/ignite/pull/7607#discussion_r414614751



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMXBeanImpl.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.List;
+import org.apache.ignite.internal.GridKernalContextImpl;
+import org.apache.ignite.mxbean.SnapshotMXBean;
+
+/**
+ * Snapshot MBean features.
+ */
+public class SnapshotMXBeanImpl implements SnapshotMXBean {
+    /** Instance of snapshot cache shared manager. */
+    private final IgniteSnapshotManager mgr;
+
+    /**
+     * @param ctx Kernal context.
+     */
+    public SnapshotMXBeanImpl(GridKernalContextImpl ctx) {
+        mgr = ctx.cache().context().snapshotMgr();
+    }
+
+    /** {@inheritDoc} */
+    @Override public void createSnapshot(String snpName) {
+        mgr.createSnapshot(snpName).get();

Review comment:
       Hello @Mmuzaf,
   Do we really need to publish this functionality through JMX? What is the reason to do that?
   We already have activation/deactivation, stop txs, killing queries and tasks, etc.
   Why do we try to duplicate **all** java API's here? Is it really needed and useful?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org