You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2019/08/21 16:35:54 UTC

[qpid-broker-j] 12/21: QPID-8350: [Tests][AMQP 1.0] Improve attach tests

This is an automated email from the ASF dual-hosted git repository.

orudyy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-broker-j.git

commit 62484c7f297e55435ce2c3288027677255651873
Author: Alex Rudyy <or...@apache.org>
AuthorDate: Mon Aug 19 14:27:31 2019 +0100

    QPID-8350: [Tests][AMQP 1.0] Improve attach tests
---
 .../apache/qpid/tests/protocol/v1_0/transport/link/AttachTest.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/transport/link/AttachTest.java b/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/transport/link/AttachTest.java
index c81e950..75f5985 100644
--- a/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/transport/link/AttachTest.java
+++ b/systests/protocol-tests-amqp-1-0/src/test/java/org/apache/qpid/tests/protocol/v1_0/transport/link/AttachTest.java
@@ -46,12 +46,13 @@ import org.apache.qpid.tests.protocol.v1_0.Interaction;
 import org.apache.qpid.tests.protocol.SpecificationTest;
 import org.apache.qpid.tests.utils.BrokerAdmin;
 import org.apache.qpid.tests.utils.BrokerAdminUsingTestBase;
+import org.apache.qpid.tests.utils.BrokerSpecific;
 
 public class AttachTest extends BrokerAdminUsingTestBase
 {
     @Test
     @SpecificationTest(section = "1.3.4",
-            description = "Attach without mandatory fields should result in a decoding error.")
+            description = "mandatory [...] a non null value for the field is always encoded.")
     public void emptyAttach() throws Exception
     {
         final InetSocketAddress addr = getBrokerAdmin().getBrokerAddress(BrokerAdmin.PortType.ANONYMOUS_AMQP);
@@ -128,6 +129,7 @@ public class AttachTest extends BrokerAdminUsingTestBase
                           + " still create a link endpoint and issue an attach indicating that the link endpoint has"
                           + " no associated local terminus. In this case, the session endpoint MUST immediately"
                           + " detach the newly created link endpoint.")
+    @BrokerSpecific(kind = BrokerAdmin.KIND_BROKER_J)
     public void attachReceiverWithNullTarget() throws Exception
     {
         String queueName = BrokerAdmin.TEST_QUEUE_NAME;
@@ -170,6 +172,7 @@ public class AttachTest extends BrokerAdminUsingTestBase
                           + " still create a link endpoint and issue an attach indicating that the link endpoint has"
                           + " no associated local terminus. In this case, the session endpoint MUST immediately"
                           + " detach the newly created link endpoint.")
+    @BrokerSpecific(kind = BrokerAdmin.KIND_BROKER_J)
     public void attachSenderWithNullSource() throws Exception
     {
         String queueName = "testQueue";


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org