You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2023/11/28 09:12:14 UTC
Re: Review Request 74538: RANGER-4345 plugin side metrics on polling from the policy server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74538/#review226013
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
Lines 55 (patched)
<https://reviews.apache.org/r/74538/#comment314364>
Are we adding metrics only for Policy download ?.It would be great if you add the same for roles as well.The policy refresher thread will download policies as well as roles also.
- Ramachandran Krishnan
On Aug. 11, 2023, 9:05 a.m., Sai Sandeep Rangisetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74538/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2023, 9:05 a.m.)
>
>
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramachandran Krishnan.
>
>
> Bugs: RANGER-4345
> https://issues.apache.org/jira/browse/RANGER-4345
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add metrics in the plugins for increased visibility on what is happening in the systems
>
>
> Diffs
> -----
>
> agents-common/pom.xml b753c1368
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java c130309ea
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricRegistry.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403
>
>
> Diff: https://reviews.apache.org/r/74538/diff/4/
>
>
> Testing
> -------
>
> Compiled and installed the hbase plugin and verified that metrics are being published to jmx. Simulated failures by blocking port and verified timeout and retry metrics are also being published
>
>
> Thanks,
>
> Sai Sandeep Rangisetti
>
>
Re: Review Request 74538: RANGER-4345 plugin side metrics on polling from the policy server
Posted by Sai Sandeep Rangisetti via Review Board <no...@reviews.apache.org>.
> On Nov. 28, 2023, 9:12 a.m., Ramachandran Krishnan wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/74538/diff/2/?file=2278101#file2278101line55>
> >
> > Are we adding metrics only for Policy download ?.It would be great if you add the same for roles as well.The policy refresher thread will download policies as well as roles also.
RangerRESTClient should handle all the API calls including policy download and role download. I had added additional metrics for roles just like for policies
- Sai Sandeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74538/#review226013
-----------------------------------------------------------
On Dec. 13, 2023, 10:45 a.m., Sai Sandeep Rangisetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74538/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2023, 10:45 a.m.)
>
>
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramachandran Krishnan.
>
>
> Bugs: RANGER-4345
> https://issues.apache.org/jira/browse/RANGER-4345
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add metrics in the plugins for increased visibility on what is happening in the systems
>
>
> Diffs
> -----
>
> agents-common/pom.xml 12e093f78915a77a14e5489e0c9cd2492382017f
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199cb6e50b0b307471e5579f762721c89
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricRegistry.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d2207cf82838f4cae4ead63dee38069
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java 58a47cf1b07f88f06304a9ff8f4272c5e84e700a
>
>
> Diff: https://reviews.apache.org/r/74538/diff/5/
>
>
> Testing
> -------
>
> Compiled and installed the hbase plugin and verified that metrics are being published to jmx. Simulated failures by blocking port and verified timeout and retry metrics are also being published
>
>
> Thanks,
>
> Sai Sandeep Rangisetti
>
>