You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Raymond Auge <ra...@liferay.com> on 2013/06/28 17:22:42 UTC
possible webconsole bug
Hello all,
I'm testing the latest web console release (4.2.0) in a custom HttpService
and it works very well, except for one small issue which I'm not sure is a
bug in our impl, or in the web console.
All features of the web console work, with one exception (at least so far
as I've noticed).
When selecting the
Status -> System Properties
menu item, we get an error which stems from the fact that the URI returned
by the servlet request is:
/.../system/console/status-System%20Properties
Now the call is simply:
String requestURI = request.getRequestURI();
in which the servlet spec clearly states the value is NOT decoded [1]
Subsequently the PluginHolder object tries to search it's list of plugins
for:
"status-System%20Properties"
which fails to match of course.
So, who is to blame? Our HttpService? Or webconsole?
I don't really care either way, I just don't want to file a ticket if the
bug is really ours.
Sincerely,
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)
[1]
http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
Re: possible webconsole bug
Posted by Felix Meschberger <fm...@adobe.com>.
Hi Ray
Thanks for the heads up.
Glad to hear the mystery solved.
Regards
Felix
--
Felix Meschberger | Principal Scientist | fmeschbe@adobe.com
Am 28.06.2013 um 21:58 schrieb "Raymond Auge" <ra...@liferay.com>:
> Ok... that was a simple fix! The bug was in our code.
>
> When parting out the pathInfo, I forgot the decode the result which caused
> the bug.
>
> Everything works perfectly now.
>
> Thanks again for your patience.
>
> - Ray
>
>
> On Fri, Jun 28, 2013 at 3:47 PM, Raymond Auge <ra...@liferay.com>wrote:
>
>> Thanks Felix,
>>
>> As I said, it may well be a bug on our end. I probably stopped debugging a
>> little too quickly.
>>
>> I'll do a more thorough pass and let you know the outcome.
>>
>> Thanks for taking a look.
>>
>> - Ray
>>
>>
>> On Fri, Jun 28, 2013 at 3:35 PM, Felix Meschberger <fm...@adobe.com>wrote:
>>
>>> Hi Raymond
>>>
>>> Am 28.06.2013 um 17:22 schrieb Raymond Auge:
>>>
>>>> Hello all,
>>>>
>>>> I'm testing the latest web console release (4.2.0) in a custom
>>> HttpService
>>>> and it works very well, except for one small issue which I'm not sure
>>> is a
>>>> bug in our impl, or in the web console.
>>>>
>>>> All features of the web console work, with one exception (at least so
>>> far
>>>> as I've noticed).
>>>>
>>>> When selecting the
>>>>
>>>> Status -> System Properties
>>>>
>>>> menu item, we get an error which stems from the fact that the URI
>>> returned
>>>> by the servlet request is:
>>>>
>>>> /.../system/console/status-System%20Properties
>>>>
>>>> Now the call is simply:
>>>>
>>>> String requestURI = request.getRequestURI();
>>>
>>> Actually, the interesting call is (first line in the request method):
>>>
>>>> final String pathInfo = request.getPathInfo();
>>>
>>> Which is decoded.
>>>
>>> The getRequestURI method is only used to redirect in case the path info
>>> is null.
>>>
>>> This all sounds strange. Never heard of an issue like this before.
>>>
>>> Regards
>>> Felix
>>>
>>>
>>>>
>>>> in which the servlet spec clearly states the value is NOT decoded [1]
>>>>
>>>> Subsequently the PluginHolder object tries to search it's list of
>>> plugins
>>>> for:
>>>>
>>>> "status-System%20Properties"
>>>>
>>>> which fails to match of course.
>>>>
>>>> So, who is to blame? Our HttpService? Or webconsole?
>>>>
>>>> I don't really care either way, I just don't want to file a ticket if
>>> the
>>>> bug is really ours.
>>>>
>>>> Sincerely,
>>>> --
>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>> (@rotty3000)
>>>> Senior Software Architect
>>>> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>>>>
>>>> [1]
>>> http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
>>
>>
>> --
>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>> (@rotty3000)
>> Senior Software Architect
>> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> (@rotty3000)
> Senior Software Architect
> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
Re: possible webconsole bug
Posted by Raymond Auge <ra...@liferay.com>.
Ok... that was a simple fix! The bug was in our code.
When parting out the pathInfo, I forgot the decode the result which caused
the bug.
Everything works perfectly now.
Thanks again for your patience.
- Ray
On Fri, Jun 28, 2013 at 3:47 PM, Raymond Auge <ra...@liferay.com>wrote:
> Thanks Felix,
>
> As I said, it may well be a bug on our end. I probably stopped debugging a
> little too quickly.
>
> I'll do a more thorough pass and let you know the outcome.
>
> Thanks for taking a look.
>
> - Ray
>
>
> On Fri, Jun 28, 2013 at 3:35 PM, Felix Meschberger <fm...@adobe.com>wrote:
>
>> Hi Raymond
>>
>> Am 28.06.2013 um 17:22 schrieb Raymond Auge:
>>
>> > Hello all,
>> >
>> > I'm testing the latest web console release (4.2.0) in a custom
>> HttpService
>> > and it works very well, except for one small issue which I'm not sure
>> is a
>> > bug in our impl, or in the web console.
>> >
>> > All features of the web console work, with one exception (at least so
>> far
>> > as I've noticed).
>> >
>> > When selecting the
>> >
>> > Status -> System Properties
>> >
>> > menu item, we get an error which stems from the fact that the URI
>> returned
>> > by the servlet request is:
>> >
>> > /.../system/console/status-System%20Properties
>> >
>> > Now the call is simply:
>> >
>> > String requestURI = request.getRequestURI();
>>
>> Actually, the interesting call is (first line in the request method):
>>
>> > final String pathInfo = request.getPathInfo();
>>
>> Which is decoded.
>>
>> The getRequestURI method is only used to redirect in case the path info
>> is null.
>>
>> This all sounds strange. Never heard of an issue like this before.
>>
>> Regards
>> Felix
>>
>>
>> >
>> > in which the servlet spec clearly states the value is NOT decoded [1]
>> >
>> > Subsequently the PluginHolder object tries to search it's list of
>> plugins
>> > for:
>> >
>> > "status-System%20Properties"
>> >
>> > which fails to match of course.
>> >
>> > So, who is to blame? Our HttpService? Or webconsole?
>> >
>> > I don't really care either way, I just don't want to file a ticket if
>> the
>> > bug is really ours.
>> >
>> > Sincerely,
>> > --
>> > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>> > (@rotty3000)
>> > Senior Software Architect
>> > *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>> >
>> > [1]
>> >
>> http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
>>
>>
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> (@rotty3000)
> Senior Software Architect
> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)
Re: possible webconsole bug
Posted by Raymond Auge <ra...@liferay.com>.
Thanks Felix,
As I said, it may well be a bug on our end. I probably stopped debugging a
little too quickly.
I'll do a more thorough pass and let you know the outcome.
Thanks for taking a look.
- Ray
On Fri, Jun 28, 2013 at 3:35 PM, Felix Meschberger <fm...@adobe.com>wrote:
> Hi Raymond
>
> Am 28.06.2013 um 17:22 schrieb Raymond Auge:
>
> > Hello all,
> >
> > I'm testing the latest web console release (4.2.0) in a custom
> HttpService
> > and it works very well, except for one small issue which I'm not sure is
> a
> > bug in our impl, or in the web console.
> >
> > All features of the web console work, with one exception (at least so far
> > as I've noticed).
> >
> > When selecting the
> >
> > Status -> System Properties
> >
> > menu item, we get an error which stems from the fact that the URI
> returned
> > by the servlet request is:
> >
> > /.../system/console/status-System%20Properties
> >
> > Now the call is simply:
> >
> > String requestURI = request.getRequestURI();
>
> Actually, the interesting call is (first line in the request method):
>
> > final String pathInfo = request.getPathInfo();
>
> Which is decoded.
>
> The getRequestURI method is only used to redirect in case the path info is
> null.
>
> This all sounds strange. Never heard of an issue like this before.
>
> Regards
> Felix
>
>
> >
> > in which the servlet spec clearly states the value is NOT decoded [1]
> >
> > Subsequently the PluginHolder object tries to search it's list of plugins
> > for:
> >
> > "status-System%20Properties"
> >
> > which fails to match of course.
> >
> > So, who is to blame? Our HttpService? Or webconsole?
> >
> > I don't really care either way, I just don't want to file a ticket if the
> > bug is really ours.
> >
> > Sincerely,
> > --
> > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> > (@rotty3000)
> > Senior Software Architect
> > *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
> >
> > [1]
> >
> http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
>
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)
Re: possible webconsole bug
Posted by Felix Meschberger <fm...@adobe.com>.
Hi Raymond
Am 28.06.2013 um 17:22 schrieb Raymond Auge:
> Hello all,
>
> I'm testing the latest web console release (4.2.0) in a custom HttpService
> and it works very well, except for one small issue which I'm not sure is a
> bug in our impl, or in the web console.
>
> All features of the web console work, with one exception (at least so far
> as I've noticed).
>
> When selecting the
>
> Status -> System Properties
>
> menu item, we get an error which stems from the fact that the URI returned
> by the servlet request is:
>
> /.../system/console/status-System%20Properties
>
> Now the call is simply:
>
> String requestURI = request.getRequestURI();
Actually, the interesting call is (first line in the request method):
> final String pathInfo = request.getPathInfo();
Which is decoded.
The getRequestURI method is only used to redirect in case the path info is null.
This all sounds strange. Never heard of an issue like this before.
Regards
Felix
>
> in which the servlet spec clearly states the value is NOT decoded [1]
>
> Subsequently the PluginHolder object tries to search it's list of plugins
> for:
>
> "status-System%20Properties"
>
> which fails to match of course.
>
> So, who is to blame? Our HttpService? Or webconsole?
>
> I don't really care either way, I just don't want to file a ticket if the
> bug is really ours.
>
> Sincerely,
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> (@rotty3000)
> Senior Software Architect
> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>
> [1]
> http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
Re: possible webconsole bug
Posted by Raymond Auge <ra...@liferay.com>.
btw, same issue for
Status -> Wire Admin
On Fri, Jun 28, 2013 at 11:22 AM, Raymond Auge <ra...@liferay.com>wrote:
> Hello all,
>
> I'm testing the latest web console release (4.2.0) in a custom HttpService
> and it works very well, except for one small issue which I'm not sure is a
> bug in our impl, or in the web console.
>
> All features of the web console work, with one exception (at least so far
> as I've noticed).
>
> When selecting the
>
> Status -> System Properties
>
> menu item, we get an error which stems from the fact that the URI returned
> by the servlet request is:
>
> /.../system/console/status-System%20Properties
>
> Now the call is simply:
>
> String requestURI = request.getRequestURI();
>
> in which the servlet spec clearly states the value is NOT decoded [1]
>
> Subsequently the PluginHolder object tries to search it's list of plugins
> for:
>
> "status-System%20Properties"
>
> which fails to match of course.
>
> So, who is to blame? Our HttpService? Or webconsole?
>
> I don't really care either way, I just don't want to file a ticket if the
> bug is really ours.
>
> Sincerely,
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> (@rotty3000)
> Senior Software Architect
> *Liferay, Inc.* <http://www.liferay.com> (@Liferay)
>
> [1]
> http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#getRequestURI()
>
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)