You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/11/17 18:57:42 UTC
Review Request 28058: Pull Metrics struct out of Slave class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2051
https://issues.apache.org/jira/browse/MESOS-2051
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
src/slave/metrics.hpp PRE-CREATION
src/slave/metrics.cpp PRE-CREATION
src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
Diff: https://reviews.apache.org/r/28058/diff/
Testing
-------
added new test and ran make check
Thanks,
Dominic Hamon
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 18, 2014, 11:49 a.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp, lines 152-153
> > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152>
> >
> > Why start the master?
>
> Dominic Hamon wrote:
> when i didn't, the slave complained that no master could be found and the test failed.
>
> Vinod Kone wrote:
> that's unexpected. do you know why?
cluster.hpp 411:
CHECK(masters.size() == 1);
Part of the master detector stuff in cluster called from Slaves::start. Seems fairly expected to me :)
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------
On Nov. 18, 2014, 10:41 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 10:41 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 18, 2014, 7:49 p.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp, lines 152-153
> > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152>
> >
> > Why start the master?
>
> Dominic Hamon wrote:
> when i didn't, the slave complained that no master could be found and the test failed.
>
> Vinod Kone wrote:
> that's unexpected. do you know why?
>
> Dominic Hamon wrote:
> cluster.hpp 411:
>
> CHECK(masters.size() == 1);
>
> Part of the master detector stuff in cluster called from Slaves::start. Seems fairly expected to me :)
You can use StartSlave() overload that takes a StandaloneDetector.
```
StandaloneMasterDetector detector;
Try<PID<Slave> > slave = StartSlave(&detector);
```
Does that work?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------
On Nov. 18, 2014, 9 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 9 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 18, 2014, 7:49 p.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp, lines 152-153
> > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152>
> >
> > Why start the master?
>
> Dominic Hamon wrote:
> when i didn't, the slave complained that no master could be found and the test failed.
that's unexpected. do you know why?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------
On Nov. 18, 2014, 6:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 6:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 18, 2014, 11:49 a.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp, lines 152-153
> > <https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152>
> >
> > Why start the master?
when i didn't, the slave complained that no master could be found and the test failed.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------
On Nov. 18, 2014, 10:41 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 10:41 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
-----------------------------------------------------------
src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/28058/#comment103913>
2 blank lines.
src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/28058/#comment103915>
Why start the master?
- Vinod Kone
On Nov. 18, 2014, 6:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 6:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61989
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28058]
All tests passed.
- Mesos ReviewBot
On Nov. 18, 2014, 6:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 6:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review62019
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28058]
All tests passed.
- Mesos ReviewBot
On Nov. 18, 2014, 9 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 9 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review62215
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28058]
All tests passed.
- Mesos ReviewBot
On Nov. 19, 2014, 7:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 7:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review62210
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 19, 2014, 7:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28058/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 7:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2051
> https://issues.apache.org/jira/browse/MESOS-2051
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
> src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
> src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
> src/slave/metrics.hpp PRE-CREATION
> src/slave/metrics.cpp PRE-CREATION
> src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
> src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
> src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
>
> Diff: https://reviews.apache.org/r/28058/diff/
>
>
> Testing
> -------
>
> added new test and ran make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 11:35 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
added TODO
Bugs: MESOS-2051
https://issues.apache.org/jira/browse/MESOS-2051
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
src/slave/metrics.hpp PRE-CREATION
src/slave/metrics.cpp PRE-CREATION
src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
Diff: https://reviews.apache.org/r/28058/diff/
Testing
-------
added new test and ran make check
Thanks,
Dominic Hamon
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 11:27 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
added master creation back in to slave test.
Bugs: MESOS-2051
https://issues.apache.org/jira/browse/MESOS-2051
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
src/slave/metrics.hpp PRE-CREATION
src/slave/metrics.cpp PRE-CREATION
src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
Diff: https://reviews.apache.org/r/28058/diff/
Testing
-------
added new test and ran make check
Thanks,
Dominic Hamon
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 1 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2051
https://issues.apache.org/jira/browse/MESOS-2051
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
src/slave/metrics.hpp PRE-CREATION
src/slave/metrics.cpp PRE-CREATION
src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
Diff: https://reviews.apache.org/r/28058/diff/
Testing
-------
added new test and ran make check
Thanks,
Dominic Hamon
Re: Review Request 28058: Pull Metrics struct out of Slave class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 10:41 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
rebased
Bugs: MESOS-2051
https://issues.apache.org/jira/browse/MESOS-2051
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38
src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a
src/slave/metrics.hpp PRE-CREATION
src/slave/metrics.cpp PRE-CREATION
src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761
src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f
src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124
Diff: https://reviews.apache.org/r/28058/diff/
Testing
-------
added new test and ran make check
Thanks,
Dominic Hamon