[GitHub] [hudi] nsivabalan commented on a change in pull request #2438: [HUDI-1447] DeltaStreamer kafka source supports consuming from specified timestamp

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r663377708



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -282,6 +301,36 @@ private Long delayOffsetCalculation(Option<String> lastCheckpointStr, Set<TopicP
     return delayCount;
   }
 
+  /**
+   * Get the checkpoint by timestamp.
+   * @param consumer

Review comment:
       can you please add some documentation on whats happening here. format etc. an example would be great. 

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -270,6 +280,15 @@ public KafkaOffsetGen(TypedProperties props) {
     return checkpointOffsetReseter ? earliestOffsets : checkpointOffsets;
   }
 
+  private Boolean checkLastCheckpointType(Option<String> lastCheckpointStr) {

Review comment:
       should we name this "isValidCheckpointType" or something? also, can you add java docs as to what validation we are doing here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org