[jira] [Commented] (PHOENIX-858) Unit test IsNullIT#testIsNullAsSingleKey fails in master & 4.0 branch

["Gabriel Reid (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937484#comment-13937484 ] 

Gabriel Reid commented on PHOENIX-858:
--------------------------------------

I think this is a duplicate of PHOENIX-855, although with a different approach proposed to resolve it. 

If I'm reading the patch correctly, I think it would pretty much be the equivalent to just remove IsNullIT#testIsNullAsSingleKey completely, as it's not really testing anything related to null values anymore, correct? That being said, I'm more in favor of taking the approach outlined in PHOENIX-855.

> Unit test IsNullIT#testIsNullAsSingleKey fails in master & 4.0 branch
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-858
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-858
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: phoenix-858.patch
>
>
> Here is the error stack which is due to hbase0.98+ code doesn't allow empty row
> {code}
> testIsNullAsSingleKey(org.apache.phoenix.end2end.IsNullIT)  Time elapsed: 0.214 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Row length is 0
>         at org.apache.hadoop.hbase.client.Mutation.checkRow(Mutation.java:512)
>         at org.apache.hadoop.hbase.client.Put.<init>(Put.java:106)
>         at org.apache.hadoop.hbase.client.Put.<init>(Put.java:64)
>         at org.apache.hadoop.hbase.client.Put.<init>(Put.java:54)
>         at org.apache.phoenix.schema.PTableImpl$PRowImpl.newMutations(PTableImpl.java:560)
>         at org.apache.phoenix.schema.PTableImpl$PRowImpl.<init>(PTableImpl.java:555)
>         at org.apache.phoenix.schema.PTableImpl.newRow(PTableImpl.java:480)
>         at org.apache.phoenix.schema.PTableImpl.newRow(PTableImpl.java:496)
>         at org.apache.phoenix.execute.MutationState.addRowMutations(MutationState.java:173)
>         at org.apache.phoenix.execute.MutationState.commit(MutationState.java:345)
>         at org.apache.phoenix.jdbc.PhoenixConnection.commit(PhoenixConnection.java:356)
>         at org.apache.phoenix.end2end.IsNullIT.testIsNullAsSingleKey(IsNullIT.java:83)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)