You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/08/04 17:37:23 UTC
svn commit: r1510210 - /tomcat/trunk/build.xml
Author: markt
Date: Sun Aug 4 15:37:23 2013
New Revision: 1510210
URL: http://svn.apache.org/r1510210
Log:
Treat javax.servlet.ServletContainerInitializer files as text in source
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1510210&r1=1510209&r2=1510210&view=diff
==============================================================================
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Sun Aug 4 15:37:23 2013
@@ -226,6 +226,7 @@
<include name="**/LICENSE"/>
<include name="**/NOTICE"/>
<include name="**/RELEASE-NOTES"/>
+ <include name="**/javax.servlet.ServletContainerInitializer"/>
<include name="**/.gitignore"/>
<include name="**/*.classpath"/>
<include name="**/*.css"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 4, 2013, at 2:40 PM, Mark Thomas wrote:
> On 04/08/2013 21:31, Nick Williams wrote:
>>
>> On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote:
>>
>>> On 04/08/2013 21:02, Jeremy Boynes wrote:
>>>> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>>>>> Log:
>>>>> Treat javax.servlet.ServletContainerInitializer files as text in source
>>>>> <include name="**/NOTICE"/>
>>>>> <include name="**/RELEASE-NOTES"/>
>>>>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>>>>> <include name="**/.gitignore"/>
>>>>
>>>> Would this work to catch all service config files not just SCIs?
>>>> <include name="**/META-INF/services/*"/>
>>>
>>> What other ones are you expecting to find in the Tomcat source code?
>>>
>>> Mark
>>
>> Didn't someone say something about switching to an SCI to initialize Jasper in TC8?
>
> Which would still match the current pattern.
>
> Mark
Yea. I realized my stupidity right after I pressed "send." :-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Mark Thomas <ma...@apache.org>.
On 04/08/2013 21:31, Nick Williams wrote:
>
> On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote:
>
>> On 04/08/2013 21:02, Jeremy Boynes wrote:
>>> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>>>> Log:
>>>> Treat javax.servlet.ServletContainerInitializer files as text in source
>>>> <include name="**/NOTICE"/>
>>>> <include name="**/RELEASE-NOTES"/>
>>>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>>>> <include name="**/.gitignore"/>
>>>
>>> Would this work to catch all service config files not just SCIs?
>>> <include name="**/META-INF/services/*"/>
>>
>> What other ones are you expecting to find in the Tomcat source code?
>>
>> Mark
>
> Didn't someone say something about switching to an SCI to initialize Jasper in TC8?
Which would still match the current pattern.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote:
> On 04/08/2013 21:02, Jeremy Boynes wrote:
>> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>>> Log:
>>> Treat javax.servlet.ServletContainerInitializer files as text in source
>>> <include name="**/NOTICE"/>
>>> <include name="**/RELEASE-NOTES"/>
>>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>>> <include name="**/.gitignore"/>
>>
>> Would this work to catch all service config files not just SCIs?
>> <include name="**/META-INF/services/*"/>
>
> What other ones are you expecting to find in the Tomcat source code?
>
> Mark
Didn't someone say something about switching to an SCI to initialize Jasper in TC8?
N
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Mark Thomas <ma...@apache.org>.
On 04/08/2013 21:32, Jeremy Boynes wrote:
> On Aug 4, 2013, at 12:27 PM, Mark Thomas <ma...@apache.org> wrote:
>
>> On 04/08/2013 21:02, Jeremy Boynes wrote:
>>> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>>>> Log:
>>>> Treat javax.servlet.ServletContainerInitializer files as text in source
>>>> <include name="**/NOTICE"/>
>>>> <include name="**/RELEASE-NOTES"/>
>>>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>>>> <include name="**/.gitignore"/>
>>>
>>> Would this work to catch all service config files not just SCIs?
>>> <include name="**/META-INF/services/*"/>
>>
>> What other ones are you expecting to find in the Tomcat source code?
>
> None as yet, just thinking :)
> It was more "all files in META-INF/services would be text and calling out SCI is being very specific)
Then lets stick with the narrower definition until such time as we need
to consider widening it.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Jeremy Boynes <jb...@apache.org>.
On Aug 4, 2013, at 12:27 PM, Mark Thomas <ma...@apache.org> wrote:
> On 04/08/2013 21:02, Jeremy Boynes wrote:
>> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>>> Log:
>>> Treat javax.servlet.ServletContainerInitializer files as text in source
>>> <include name="**/NOTICE"/>
>>> <include name="**/RELEASE-NOTES"/>
>>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>>> <include name="**/.gitignore"/>
>>
>> Would this work to catch all service config files not just SCIs?
>> <include name="**/META-INF/services/*"/>
>
> What other ones are you expecting to find in the Tomcat source code?
None as yet, just thinking :)
It was more "all files in META-INF/services would be text and calling out SCI is being very specific)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Mark Thomas <ma...@apache.org>.
On 04/08/2013 21:02, Jeremy Boynes wrote:
> On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
>> Log:
>> Treat javax.servlet.ServletContainerInitializer files as text in source
>> <include name="**/NOTICE"/>
>> <include name="**/RELEASE-NOTES"/>
>> + <include name="**/javax.servlet.ServletContainerInitializer"/>
>> <include name="**/.gitignore"/>
>
> Would this work to catch all service config files not just SCIs?
> <include name="**/META-INF/services/*"/>
What other ones are you expecting to find in the Tomcat source code?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
Posted by Jeremy Boynes <jb...@apache.org>.
On Aug 4, 2013, at 8:37 AM, markt@apache.org wrote:
> Log:
> Treat javax.servlet.ServletContainerInitializer files as text in source
> <include name="**/NOTICE"/>
> <include name="**/RELEASE-NOTES"/>
> + <include name="**/javax.servlet.ServletContainerInitializer"/>
> <include name="**/.gitignore"/>
Would this work to catch all service config files not just SCIs?
<include name="**/META-INF/services/*"/>