You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/08/26 05:40:19 UTC

[kudu-CR](gh-pages) website: update committers page 

Hello Adar Dembo, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14141

to review the following change.


Change subject: website: update committers page
......................................................................

website: update committers page

This adds committership guidelines to the commiters, and adds the newest
Kudu PMC members.

A rendered version can be found here:
https://github.com/andrwng/kudu/blob/committership/committers.md

Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
---
M committers.md
1 file changed, 43 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14141/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14141/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14141/2//COMMIT_MSG@2
PS2, Line 2: ong <awong@apach
> Not part of the commit, but I was just curious: any specific reason to use 
I put this patch together on my personal machine that I haven't fully set up with the proper credentials.



-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:46:53 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] update committers page

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:43:13 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 21:10:49 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4:

I'll let this sit in case Adar (or anyone else) has comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 21:11:05 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14141

to look at the new patch set (#4).

Change subject: [site] update committers page
......................................................................

[site] update committers page

This adds committership guidelines to the commiters page, adds the
newest Kudu PMC members, and updates the VP.

A rendered version can be found here:
https://github.com/andrwng/kudu/blob/committership/committers.md

Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
---
M committers.md
1 file changed, 45 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14141/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR](gh-pages) [site] update committers page

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 22:37:19 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 22:18:57 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 21:10:28 +0000
Gerrit-HasComments: No

[kudu-CR](gh-pages) [site] update committers page

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14141/2/committers.md
File committers.md:

http://gerrit.cloudera.org:8080/#/c/14141/2/committers.md@16
PS2, Line 16: PMC
I thought Adar is a VP now, as well?  Or not yet officially?



-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:19:36 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14141/2/committers.md
File committers.md:

http://gerrit.cloudera.org:8080/#/c/14141/2/committers.md@16
PS2, Line 16: VP,
> I thought Adar is a VP now, as well?  Or not yet officially?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:49:22 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14141

to look at the new patch set (#2).

Change subject: [site] update committers page
......................................................................

[site] update committers page

This adds committership guidelines to the commiters page, and adds the
newest Kudu PMC members.

A rendered version can be found here:
https://github.com/andrwng/kudu/blob/committership/committers.md

Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
---
M committers.md
1 file changed, 43 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14141/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR](gh-pages) [site] update committers page

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14141/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14141/2//COMMIT_MSG@2
PS2, Line 2: anjuwo@gmail.com
Not part of the commit, but I was just curious: any specific reason to use this e-mail address instead of awong@apache.org  ?



-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:22:44 +0000
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14141 )

Change subject: [site] update committers page
......................................................................

[site] update committers page

This adds committership guidelines to the commiters page, adds the
newest Kudu PMC members, and updates the VP.

A rendered version can be found here:
https://github.com/andrwng/kudu/blob/committership/committers.md

Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Reviewed-on: http://gerrit.cloudera.org:8080/14141
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M committers.md
1 file changed, 45 insertions(+), 2 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Andrew Wong: Verified
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR](gh-pages) [site] update committers page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14141

to look at the new patch set (#3).

Change subject: [site] update committers page
......................................................................

[site] update committers page

This adds committership guidelines to the commiters page, and adds the
newest Kudu PMC members.

A rendered version can be found here:
https://github.com/andrwng/kudu/blob/committership/committers.md

Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
---
M committers.md
1 file changed, 43 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14141/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib37c2ef7aa76c5061af4d28857a7759462ca8b71
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>