You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:57:28 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4135: net/rpmsg: add multi-iov support
xiaoxiang781216 opened a new pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135
## Summary
Add multi-iov support for rpmsg sockets
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#discussion_r671614705
##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -991,7 +1021,7 @@ static ssize_t rpmsg_socket_send_single(FAR struct socket *psock,
if (total > ipcsize)
{
total = ipcsize;
- len = ipcsize - sizeof(*msg) + sizeof(uint32_t);
+ len = ipcsize - sizeof(*msg) - sizeof(uint32_t);
Review comment:
The original code looks good, I drop this change directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#discussion_r671444208
##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -862,13 +862,26 @@ static int rpmsg_socket_poll(FAR struct socket *psock,
return ret;
}
+static uint32_t rpmsg_socket_get_iovlen(FAR const struct iovec *buf,
+ size_t iovcnt)
Review comment:
```suggestion
size_t iovcnt)
```
nit: alignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#issuecomment-879285088
I've never worked with the RPMSG subsystem, I'd need some time to understand these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#issuecomment-880002305
Sure, the key change is support send iovec in one batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#discussion_r671443436
##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -991,7 +1021,7 @@ static ssize_t rpmsg_socket_send_single(FAR struct socket *psock,
if (total > ipcsize)
{
total = ipcsize;
- len = ipcsize - sizeof(*msg) + sizeof(uint32_t);
+ len = ipcsize - sizeof(*msg) - sizeof(uint32_t);
Review comment:
This seems to be a bugfix that is not strictly related to the new feature being added in this PR.
If so, please add it to a dedicated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4135: net/rpmsg: add multi-iov support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4135:
URL: https://github.com/apache/incubator-nuttx/pull/4135#discussion_r671614651
##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -862,13 +862,26 @@ static int rpmsg_socket_poll(FAR struct socket *psock,
return ret;
}
+static uint32_t rpmsg_socket_get_iovlen(FAR const struct iovec *buf,
+ size_t iovcnt)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org