You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/27 06:01:44 UTC

[GitHub] [spark] cloud-fan commented on issue #24699: [SPARK-27666][CORE] Stop PythonRunner's WriteThread immediately when task finishes

cloud-fan commented on issue #24699: [SPARK-27666][CORE] Stop PythonRunner's WriteThread immediately when task finishes
URL: https://github.com/apache/spark/pull/24699#issuecomment-496088487
 
 
   After a second thought, it seems overkill to block the main thread and wait for the python writer thread to exit. If something bad happens we may block the main thread for a long time or even hang.
   
   Perhaps a better solution is to add `releaseIfLocked`, which does nothing if the lock is already released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org