You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/19 11:39:22 UTC
[GitHub] [kylin] zhoukangcn opened a new pull request #1072: KYLIN-4356:
clean outdate DefaultChainedExecutable job
zhoukangcn opened a new pull request #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072
see: https://issues.apache.org/jira/browse/KYLIN-4356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997699
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/9ca3dfec2702aace60cf2ed395b2ffc94faedb54?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `20%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1072/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
===========================================
- Coverage 25% 25% -0.01%
Complexity 6228 6228
===========================================
Files 1443 1444 +1
Lines 88142 88149 +7
Branches 12337 12340 +3
===========================================
- Hits 22043 22040 -3
- Misses 63933 63941 +8
- Partials 2166 2168 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/kylin/job/execution/CardinalityExecutable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2FyZGluYWxpdHlFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `13.79% <0%> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (-1.64%)` | `26 <0> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...pache/kylin/job/impl/curator/CuratorScheduler.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL2N1cmF0b3IvQ3VyYXRvclNjaGVkdWxlci5qYXZh) | `64.4% <0%> (-0.85%)` | `7% <0%> (ø)` | |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=footer). Last update [9ca3dfe...533dc20](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen commented on issue #1072: KYLIN-4356: clean
outdate DefaultChainedExecutable job
Posted by GitBox <gi...@apache.org>.
nichunen commented on issue #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-577077890
Will this forcedly delete all jobs with types that are not CubingJob? If so, I doubt it's not a good way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997883
## Pull Request Test Coverage Report for [Build 5624](https://coveralls.io/builds/28759113)
* **4** of **12** **(33.33%)** changed or added relevant lines in **3** files are covered.
* **7** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.0006%**) to **27.524%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/execution/CardinalityExecutable.java](https://coveralls.io/builds/28759113/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FCardinalityExecutable.java#L27) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28759113/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L204) | 4 | 7 | 57.14%
| [server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/28759113/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L480) | 0 | 3 | 0.0%
<!-- | **Total:** | **4** | **12** | **33.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28759113/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L211) | 1 | 70.42% |
| [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/28759113/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28759113/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28759113/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
<!-- | **Total:** | **7** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28759113/badge)](https://coveralls.io/builds/28759113) |
| :-- | --: |
| Change from base [Build 5622](https://coveralls.io/builds/28756810): | 0.0006% |
| Covered Lines: | 24191 |
| Relevant Lines: | 87891 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997883
## Pull Request Test Coverage Report for [Build 5657](https://coveralls.io/builds/28937647)
* **4** of **10** **(40.0%)** changed or added relevant lines in **3** files are covered.
* **2** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.003%**) to **27.466%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/28937647/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L493) | 0 | 1 | 0.0%
| [core-job/src/main/java/org/apache/kylin/job/execution/CardinalityExecutable.java](https://coveralls.io/builds/28937647/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FCardinalityExecutable.java#L27) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28937647/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L204) | 4 | 7 | 57.14%
<!-- | **Total:** | **4** | **10** | **40.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/28937647/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L145) | 1 | 68.64% |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28937647/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L211) | 1 | 70.42% |
<!-- | **Total:** | **2** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28937647/badge)](https://coveralls.io/builds/28937647) |
| :-- | --: |
| Change from base [Build 5648](https://coveralls.io/builds/28893242): | 0.003% |
| Covered Lines: | 24211 |
| Relevant Lines: | 88149 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1072: KYLIN-4356: clean
outdate DefaultChainedExecutable job
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997883
## Pull Request Test Coverage Report for [Build 5538](https://coveralls.io/builds/28195649)
* **4** of **7** **(57.14%)** changed or added relevant lines in **1** file are covered.
* **5** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.004%**) to **27.512%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28195649/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L204) | 4 | 7 | 57.14%
<!-- | **Total:** | **4** | **7** | **57.14%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28195649/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28195649/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28195649/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L211) | 1 | 70.42% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28195649/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
<!-- | **Total:** | **5** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28195649/badge)](https://coveralls.io/builds/28195649) |
| :-- | --: |
| Change from base [Build 5537](https://coveralls.io/builds/28193424): | -0.004% |
| Covered Lines: | 24138 |
| Relevant Lines: | 87735 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] zhoukangcn commented on issue #1072: KYLIN-4356: clean
outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
zhoukangcn commented on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-586791168
@nichunen code updated, please help to review it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997699
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/908ea305334beb631f7b42fcd1e6b8e461d0dfa9?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `16.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1072/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
- Coverage 25.06% 25.06% -0.01%
+ Complexity 6226 6225 -1
============================================
Files 1440 1441 +1
Lines 87882 87891 +9
Branches 12291 12294 +3
============================================
- Hits 22030 22026 -4
- Misses 63694 63704 +10
- Partials 2158 2161 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/kylin/job/execution/CardinalityExecutable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2FyZGluYWxpdHlFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `13.68% <0%> (-0.11%)` | `9 <0> (ø)` | |
| [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (-1.64%)` | `26 <0> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=footer). Last update [908ea30...47585bf](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1072: KYLIN-4356:
clean outdate DefaultChainedExecutable job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997699
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/43b248d807cea23c648b8cc730d94901f3635d42?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `16.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1072/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
- Coverage 25.07% 25.06% -0.02%
- Complexity 6223 6225 +2
============================================
Files 1438 1441 +3
Lines 87730 87891 +161
Branches 12257 12294 +37
============================================
+ Hits 21995 22026 +31
- Misses 63588 63704 +116
- Partials 2147 2161 +14
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/kylin/job/execution/CardinalityExecutable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2FyZGluYWxpdHlFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `13.68% <0%> (-0.11%)` | `9 <0> (ø)` | |
| [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (-1.64%)` | `26 <0> (ø)` | |
| [...engine/spark/util/PercentileCounterSerializer.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvdXRpbC9QZXJjZW50aWxlQ291bnRlclNlcmlhbGl6ZXIuamF2YQ==) | `90.47% <0%> (-9.53%)` | `3% <0%> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [.../org/apache/kylin/dict/lookup/SnapshotManager.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9TbmFwc2hvdE1hbmFnZXIuamF2YQ==) | `68.5% <0%> (-4.38%)` | `30% <0%> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
| [...ylin/metadata/badquery/BadQueryHistoryManager.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvYmFkcXVlcnkvQmFkUXVlcnlIaXN0b3J5TWFuYWdlci5qYXZh) | `76.66% <0%> (-2.65%)` | `9% <0%> (ø)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...n/java/org/apache/kylin/dict/NumberDictionary.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlckRpY3Rpb25hcnkuamF2YQ==) | `20% <0%> (-2.23%)` | `2% <0%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=footer). Last update [43b248d...8d1d126](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] lgtm-com[bot] commented on issue #1072: KYLIN-4356: clean
outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-590196814
This pull request **introduces 1 alert** when merging e1988a7c67ab13f0a2f585f57baa6d80dda4cb2f into 9ca3dfec2702aace60cf2ed395b2ffc94faedb54 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-894adb3f9ab3db964e624b194b0f6a7a2f8c3611)
**new alerts:**
* 1 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997699
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/9ca3dfec2702aace60cf2ed395b2ffc94faedb54?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `16.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1072/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
- Coverage 25% 24.99% -0.02%
+ Complexity 6228 6226 -2
============================================
Files 1443 1444 +1
Lines 88142 88151 +9
Branches 12337 12340 +3
============================================
- Hits 22043 22036 -7
- Misses 63933 63945 +12
- Partials 2166 2170 +4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/kylin/job/execution/CardinalityExecutable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2FyZGluYWxpdHlFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `13.68% <0%> (-0.11%)` | `9 <0> (ø)` | |
| [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (-1.64%)` | `26 <0> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-2.28%)` | `7% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...pache/kylin/job/impl/curator/CuratorScheduler.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL2N1cmF0b3IvQ3VyYXRvclNjaGVkdWxlci5qYXZh) | `64.4% <0%> (-0.85%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=footer). Last update [9ca3dfe...e1988a7](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1072: KYLIN-4356: clean
outdate DefaultChainedExecutable job
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997699
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=h1) Report
> Merging [#1072](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/43b248d807cea23c648b8cc730d94901f3635d42?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `28.57%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1072/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
- Coverage 25.06% 25.05% -0.01%
+ Complexity 6223 6222 -1
============================================
Files 1438 1438
Lines 87730 87735 +5
Branches 12257 12260 +3
============================================
- Hits 21989 21983 -6
- Misses 63593 63600 +7
- Partials 2148 2152 +4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (-1.64%)` | `26 <0> (ø)` | |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1072/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=footer). Last update [43b248d...5c14602](https://codecov.io/gh/apache/kylin/pull/1072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #1072: KYLIN-4356: clean
outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1072: KYLIN-4356:
clean outdate DefaultChainedExecutable job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1072: KYLIN-4356: clean outdate DefaultChainedExecutable job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997883
## Pull Request Test Coverage Report for [Build 5623](https://coveralls.io/builds/28758847)
* **4** of **12** **(33.33%)** changed or added relevant lines in **3** files are covered.
* **1306** unchanged lines in **35** files lost coverage.
* Overall coverage increased (+**0.006%**) to **27.523%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/execution/CardinalityExecutable.java](https://coveralls.io/builds/28758847/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FCardinalityExecutable.java#L27) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28758847/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L204) | 4 | 7 | 57.14%
| [server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/28758847/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L480) | 0 | 3 | 0.0%
<!-- | **Total:** | **4** | **12** | **33.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28758847/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28758847/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L211) | 1 | 70.42% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28758847/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
| [core-common/src/main/java/org/apache/kylin/common/util/DecimalUtil.java](https://coveralls.io/builds/28758847/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FDecimalUtil.java#L35) | 3 | 0% |
| [core-dictionary/src/main/java/org/apache/kylin/dict/NumberDictionary.java](https://coveralls.io/builds/28758847/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FNumberDictionary.java#L34) | 3 | 30.0% |
| [core-metadata/src/main/java/org/apache/kylin/metadata/badquery/BadQueryHistoryManager.java](https://coveralls.io/builds/28758847/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fbadquery%2FBadQueryHistoryManager.java#L62) | 3 | 83.33% |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigExt.java](https://coveralls.io/builds/28758847/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigExt.java#L71) | 4 | 47.83% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FragmentFilesMerger.java](https://coveralls.io/builds/28758847/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FFragmentFilesMerger.java#L352) | 4 | 97.8% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28758847/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/FetcherRunner.java](https://coveralls.io/builds/28758847/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FFetcherRunner.java#L56) | 6 | 85.37% |
<!-- | **Total:** | **1306** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28758847/badge)](https://coveralls.io/builds/28758847) |
| :-- | --: |
| Change from base [Build 5537](https://coveralls.io/builds/28193424): | 0.006% |
| Covered Lines: | 24190 |
| Relevant Lines: | 87891 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1072: KYLIN-4356:
clean outdate column cardinality job
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1072: KYLIN-4356: clean outdate column cardinality job
URL: https://github.com/apache/kylin/pull/1072#issuecomment-575997883
## Pull Request Test Coverage Report for [Build 5655](https://coveralls.io/builds/28912797)
* **4** of **12** **(33.33%)** changed or added relevant lines in **3** files are covered.
* **8** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.0006%**) to **27.463%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-job/src/main/java/org/apache/kylin/job/execution/CardinalityExecutable.java](https://coveralls.io/builds/28912797/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FCardinalityExecutable.java#L27) | 0 | 2 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28912797/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L204) | 4 | 7 | 57.14%
| [server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/28912797/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L480) | 0 | 3 | 0.0%
<!-- | **Total:** | **4** | **12** | **33.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/28912797/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L145) | 1 | 68.64% |
| [server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java](https://coveralls.io/builds/28912797/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FMetadataCleanupJob.java#L211) | 1 | 70.42% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28912797/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28912797/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **8** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28912797/badge)](https://coveralls.io/builds/28912797) |
| :-- | --: |
| Change from base [Build 5648](https://coveralls.io/builds/28893242): | 0.0006% |
| Covered Lines: | 24209 |
| Relevant Lines: | 88151 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services