You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/01 05:24:00 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #9947: [GH-9708] Add type annotation to providers/jenkins

turbaszek commented on a change in pull request #9947:
URL: https://github.com/apache/airflow/pull/9947#discussion_r463925080



##########
File path: airflow/providers/jenkins/hooks/jenkins.py
##########
@@ -29,7 +30,7 @@ class JenkinsHook(BaseHook):
     Hook to manage connection to jenkins server
     """
 
-    def __init__(self, conn_id='jenkins_default'):
+    def __init__(self, conn_id: Union[str, Text] = 'jenkins_default') -> None:

Review comment:
       ```suggestion
       def __init__(self, conn_id: str = 'jenkins_default') -> None:
   ```
   That's the usual type we use for connection id




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org