You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/29 19:17:38 UTC

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

pratyakshsharma commented on pull request #2768:
URL: https://github.com/apache/hudi/pull/2768#issuecomment-850885803


   > @vingov for an extra pair of eyes. @pratyakshsharma any testing done for the PR? any way to add a test for the tool?
   
   No I have not done any testing. Currently there is no test coverage for this tool. The lines of code that this PR is touching do not need any test case I believe. We can try to cover the entire tool in general with unit tests though. Do you want me to do that as part of this PR itself? @vinothchandar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org