You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/23 12:02:27 UTC
svn commit: r1883746 - in
/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox: ./ schema/ type/
Author: msahyoun
Date: Mon Nov 23 12:02:26 2020
New Revision: 1883746
URL: http://svn.apache.org/viewvc?rev=1883746&view=rev
Log:
PDFBOX-5017: Sonar fixes
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AdobePDFErrorsTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestAbstractStructuredType.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestSimpleMetadataProperties.java
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java Mon Nov 23 12:02:26 2020
@@ -30,7 +30,7 @@ import org.junit.jupiter.params.provider
class TestXMPWithDefinedSchemas
{
- public static Stream<String> initializeParameters() throws Exception
+ static Stream<String> initializeParameters() throws Exception
{
return Stream.of(
"/validxmp/override_ns.rdf",
@@ -43,7 +43,7 @@ class TestXMPWithDefinedSchemas
@ParameterizedTest
@MethodSource("initializeParameters")
- public void main(String path) throws Exception
+ void main(String path) throws Exception
{
InputStream is = this.getClass().getResourceAsStream(path);
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/XMPMetaDataTest.java Mon Nov 23 12:02:26 2020
@@ -48,7 +48,7 @@ import org.junit.jupiter.api.Test;
class XMPMetaDataTest
{
@Test
- public void testAddingSchem()
+ void testAddingSchem()
{
XMPMetadata metadata = XMPMetadata.createXMPMetadata();
String tmpNsURI = "http://www.test.org/schem/";
@@ -90,7 +90,7 @@ class XMPMetaDataTest
*/
@Test
- public void testTransformerExceptionMessage() throws XmpSerializationException
+ void testTransformerExceptionMessage() throws XmpSerializationException
{
assertThrows(org.apache.xmpbox.xml.XmpSerializationException.class, () -> {
throw new XmpSerializationException("TEST");
@@ -98,7 +98,7 @@ class XMPMetaDataTest
}
@Test
- public void testTransformerExceptionWithCause() throws XmpSerializationException
+ void testTransformerExceptionWithCause() throws XmpSerializationException
{
assertThrows(org.apache.xmpbox.xml.XmpSerializationException.class, () -> {
throw new XmpSerializationException("TEST", new Throwable());
@@ -106,7 +106,7 @@ class XMPMetaDataTest
}
@Test
- public void testInitMetaDataWithInfo() throws Exception
+ void testInitMetaDataWithInfo() throws Exception
{
String xpacketBegin = "TESTBEG", xpacketId = "TESTID", xpacketBytes = "TESTBYTES", xpacketEncoding = "TESTENCOD";
XMPMetadata metadata = XMPMetadata.createXMPMetadata(xpacketBegin, xpacketId, xpacketBytes, xpacketEncoding);
@@ -125,7 +125,7 @@ class XMPMetaDataTest
* @throws XmpParsingException
*/
@Test
- public void testPDFBOX3257() throws IOException, XmpParsingException
+ void testPDFBOX3257() throws IOException, XmpParsingException
{
// taken from file test-landscape2.pdf
String xmpmeta = "<?xpacket id=\"W5M0MpCehiHzreSzNTczkc9d\"?>\n"
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AdobePDFErrorsTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AdobePDFErrorsTest.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AdobePDFErrorsTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/AdobePDFErrorsTest.java Mon Nov 23 12:02:26 2020
@@ -80,8 +80,8 @@ class AdobePDFErrorsTest
void testBadVersionIdValueType() throws Exception
{
PDFAIdentificationSchema pdfaid = metadata.createAndAddPFAIdentificationSchema();
- assertThrows(IllegalArgumentException.class, () -> {
- pdfaid.setPartValueWithString("1");
+ pdfaid.setPartValueWithString("1");
+ assertThrows(IllegalArgumentException.class, () -> {
pdfaid.setPartValueWithString("ojoj");
});
}
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/PDFAIdentificationOthersTest.java Mon Nov 23 12:02:26 2020
@@ -74,8 +74,8 @@ class PDFAIdentificationOthersTest
{
XMPMetadata metadata = XMPMetadata.createXMPMetadata();
PDFAIdentificationSchema pdfaid = metadata.createAndAddPFAIdentificationSchema();
+ pdfaid.setPartValueWithString("1");
assertThrows(IllegalArgumentException.class, () -> {
- pdfaid.setPartValueWithString("1");
pdfaid.setPartValueWithString("ojoj");
});
}
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java Mon Nov 23 12:02:26 2020
@@ -128,7 +128,7 @@ class XMPSchemaTest
}
@Test
- public void rdfAboutTest()
+ void rdfAboutTest()
{
assertEquals("",schem.getAboutValue());
String about = "about";
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestAbstractStructuredType.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestAbstractStructuredType.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestAbstractStructuredType.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestAbstractStructuredType.java Mon Nov 23 12:02:26 2020
@@ -56,7 +56,7 @@ class TestAbstractStructuredType
protected MyStructuredType st = new MyStructuredType(xmp, MY_NS, MY_PREFIX);
@Test
- public void validate() throws Exception
+ void validate() throws Exception
{
assertEquals(MY_NS, st.getNamespace());
assertEquals(MY_PREFIX, st.getPrefix());
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestSimpleMetadataProperties.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestSimpleMetadataProperties.java?rev=1883746&r1=1883745&r2=1883746&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestSimpleMetadataProperties.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/TestSimpleMetadataProperties.java Mon Nov 23 12:02:26 2020
@@ -103,8 +103,9 @@ class TestSimpleMetadataProperties
@Test
void testTextBadTypeDetection() throws Exception
{
+ Calendar calendar = Calendar.getInstance();
assertThrows(IllegalArgumentException.class, () -> {
- new TextType(parent, null, "test", "text", Calendar.getInstance());
+ new TextType(parent, null, "test", "text", calendar);
});
}
@@ -193,8 +194,9 @@ class TestSimpleMetadataProperties
@Test
void testExceptionWithCause() throws Exception
{
+ Throwable throwable = new Throwable();
assertThrows(IllegalArgumentException.class, () -> {
- throw new IllegalArgumentException("TEST", new Throwable());
+ throw new IllegalArgumentException("TEST", throwable);
});
}