Re: Fw: Security Token Service - wsdl2java generated code

[Davanum Srinivas <da...@gmail.com>]

Malinda,

I'd usually discourage checking in code that can be generated on the
fly. Here's a plan of action.

#1 - Try latest Axis CVS and check if the same problems occur as you
previously mentioned.
#2 - If it does open up a bug report and let me know and i will add it
to my "active" list.
#3 - Once the bugs are fixed and generated code is bug free, we can
get rid of the generated code in CVS and use wsdl2java ant task to
generate the code

ok?

thanks,
dims


----- Original Message -----
From: Malinda Kaushalye <ka...@cse.mrt.ac.lk>
Date: Sat, 31 Jul 2004 15:47:56 +0600
Subject: Fw: Security Token Service - wsdl2java generated code
To: fx-dev@ws.apache.org

 
 
 
Hi All, 
  
I'm implementing WS-trsut. Dimuthu committed some of my code today.
And I'm using the ws-trust.wsdl available at
http://www-106.ibm.com/developerworks/library/specification/ws-trust/.
  
And I used wsdl2java tool to generate the security token service.
But the code generated is not error free and I sent a mail (please
refer the mail below) regarding the matter.
  
Anyway I developed the Token Issuance part using the above service and
it works fine.  But now I'm facing the problem of committing the code
(as expected).
  
Part of my code uses the generated code. 
  
Question : What should I do with the generated code? Should I commit it? 
  
Another reason for committing the generated code is that Other
code(Certain classes of Trust Implementation + WS-Secure Conversation
section that uses WS-Trust) doesn't compile without it.
  
 
Please access the org.zip (the generated service if required) using
following URL
http://www.cse.mrt.ac.lk/~kaushal/WSDL2Java_GenStuff/org.zip 
  
 
Regards,
Kaushalye 
  
  
----- Original Message ----- 
From: Malinda Kaushalye 
To: ws-fx-cvs@apache.org 
Cc: muthulee@cse.mrt.ac.lk ; axis-user@ws.apache.org ;
sanjiva@opensource.lk ; ruchith3@cse.mrt.ac.lk ; chamindra@virtusa.com
Sent: Monday, June 14, 2004 11:37 AM 
Subject: Security Token Service - wsdl2java generated code 

 
 

Hi All, 

  

I could generate the Security Token Service using wsdl2java tool with
ws-trust.wsdl and other related .xsd files.

But there are some bugs (I guess so) in the generated code. 

  

////////////////////////////////////////////////////////////// 

  

In the RequestTypeEnum class there is an unhandled
exception(MalformedURIException).

Please check the following section. 

    

public static final org.apache.axis.types.URI _value1 = new
org.apache.axis.types.URI("http://schemas.xmlsoap.org/ws/2004/04/security/trust/Issue");

public static final org.apache.axis.types.URI _value2 = new
org.apache.axis.types.URI("http://schemas.xmlsoap.org/ws/2004/04/security/trust/Renew");

public static final org.apache.axis.types.URI _value3 = new
org.apache.axis.types.URI("http://schemas.xmlsoap.org/ws/2004/04/security/trust/Validate");

  

////////////////////////////////////////////////////////////// 

  

Some return statements do not keep the space ' '  between the return
keyword and the return type.

e.g. please refer the return statement shown below... 

  

public org.xmlsoap.schemas.ws._2004._04.trust.BinarySecretTypeEnum
getBinarySecretTypeEnumValue() {       
returnorg.xmlsoap.schemas.ws._2004._04.trust.BinarySecretTypeEnum.fromString(value);

    }  

////////////////////////////////////////////////////////////// 

  

It seems the method setValue(params) cause some problems. 

e.g. 

The method setValue(URI) is undefined for the type RequestTypeOpenEnum
  File:      STSServerSideCompile/org/xmlsoap/schemas/ws/_2004/_04/trust
..RequestTypeOpenEnum.java

  

There are some other files having the same problem.         

  

////////////////////////////////////////////////////////////// 

  

Do I need to handle these errors or is it a bug (required to be fixed)
in the WSDL file (or wsdl2java tool)?

  

Thanks and regards, 

Kaushalye 



-- 
Davanum Srinivas - http://webservices.apache.org/~dims/